Opened 11 years ago

Closed 11 years ago

#6023 closed enhancement (fixed)

[with patch, positive review] Bring plot/polygon.py to 100% coverage

Reported by: kcrisman Owned by: kcrisman
Priority: minor Milestone: sage-4.0
Component: documentation Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Bring plot/polygon.py to 100% coverage.

Attachments (2)

trac_6023.patch​ (9.7 KB) - added by kcrisman 11 years ago.
trac_6023-fix.patch​ (1.2 KB) - added by kcrisman 11 years ago.

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by kcrisman

comment:1 Changed 11 years ago by kcrisman

  • Summary changed from Bring plot/polygon.py to 100% coverage to [with patch, needs review] Bring plot/polygon.py to 100% coverage

Also improves plot3d function.

See ​http://groups.google.com/group/sage-devel/browse_thread/thread/1adac4035031b140/c36f1f8a7c8a9b43#c36f1f8a7c8a9b43 for why there is no loads(dumps()) doctest.

comment:2 Changed 11 years ago by mvngu

  • Summary changed from [with patch, needs review] Bring plot/polygon.py to 100% coverage to [with patch, needs work] Bring plot/polygon.py to 100% coverage

Same issues as per ​my comment at #6006.

comment:3 Changed 11 years ago by mabshoff

  • Summary changed from [with patch, needs work] Bring plot/polygon.py to 100% coverage to [with patch, needs review] Bring plot/polygon.py to 100% coverage

No, the issue with __init__ not showing up in the documentation will be fixed in the future, i.e. sphinx 0.6.

Cheer,s

Michael

comment:4 Changed 11 years ago by kcrisman

  • Owner changed from tba to kcrisman
  • Status changed from new to assigned

Changed 11 years ago by kcrisman

comment:5 Changed 11 years ago by mvngu

  • Milestone changed from sage-4.0.1 to sage-4.0
  • Summary changed from [with patch, needs review] Bring plot/polygon.py to 100% coverage to [with patch, positive review] Bring plot/polygon.py to 100% coverage

Positive review! Apply patches in the following order:

  1. trac_6023.patch
  2. trac_6023-fix.patch

comment:6 Changed 11 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged both patches in Sage 4.0.alpha0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.