Opened 14 years ago
Closed 14 years ago
#6023 closed enhancement (fixed)
[with patch, positive review] Bring plot/polygon.py to 100% coverage
Reported by: | kcrisman | Owned by: | kcrisman |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.0 |
Component: | documentation | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Bring plot/polygon.py to 100% coverage.
Attachments (2)
Change History (8)
Changed 14 years ago by
Attachment: | trac_6023.patch added |
---|
comment:1 Changed 14 years ago by
Summary: | Bring plot/polygon.py to 100% coverage → [with patch, needs review] Bring plot/polygon.py to 100% coverage |
---|
comment:2 Changed 14 years ago by
Summary: | [with patch, needs review] Bring plot/polygon.py to 100% coverage → [with patch, needs work] Bring plot/polygon.py to 100% coverage |
---|
Same issues as per my comment at #6006.
comment:3 Changed 14 years ago by
Summary: | [with patch, needs work] Bring plot/polygon.py to 100% coverage → [with patch, needs review] Bring plot/polygon.py to 100% coverage |
---|
No, the issue with __init__
not showing up in the documentation will be fixed in the future, i.e. sphinx 0.6.
Cheer,s
Michael
comment:4 Changed 14 years ago by
Owner: | changed from tba to kcrisman |
---|---|
Status: | new → assigned |
Changed 14 years ago by
Attachment: | trac_6023-fix.patch added |
---|
comment:5 Changed 14 years ago by
Milestone: | sage-4.0.1 → sage-4.0 |
---|---|
Summary: | [with patch, needs review] Bring plot/polygon.py to 100% coverage → [with patch, positive review] Bring plot/polygon.py to 100% coverage |
Positive review! Apply patches in the following order:
trac_6023.patch
trac_6023-fix.patch
comment:6 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Merged both patches in Sage 4.0.alpha0.
Cheers,
Michael
Note: See
TracTickets for help on using
tickets.
Also improves plot3d function.
See http://groups.google.com/group/sage-devel/browse_thread/thread/1adac4035031b140/c36f1f8a7c8a9b43#c36f1f8a7c8a9b43 for why there is no loads(dumps()) doctest.