Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#6013 closed enhancement (fixed)

[with patch; positive review] rewrite number field relativize to be much faster

Reported by: ncalexan Owned by: William Stein
Priority: major Milestone: sage-4.0
Component: number theory Keywords: number field relativize speed
Cc: William Stein Craig Citro Merged in: 4.0.alpha0
Authors: Nick Alexander Reviewers: William Stein
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Patch says it best. Avoid an nfinit at all costs; allows to relativize over large number fields.

This also fixes longstanding degree one relativize bugs.

Attachments (1)

trac_6013-relativize.patch (9.0 KB) - added by ncalexan 14 years ago.

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by ncalexan

Attachment: trac_6013-relativize.patch added

comment:1 Changed 14 years ago by ncalexan

The patch is good, but I accidentally cut it from my symbolics branch. Not really a problem, but I mangled mq so the hg changeset info is wacky. Maybe best to use mq to review this, so the actual hg parent, etc, is not taken into account.

comment:2 Changed 14 years ago by William Stein

Summary: rewrite number field relativize to be much faster[with patch; positive review] rewrite number field relativize to be much faster

comment:3 Changed 14 years ago by Michael Abshoff

Milestone: sage-4.0.1sage-4.0
Resolution: fixed
Status: newclosed

Merged in Sage 4.0.alpha0.

Cheers,

Michael

comment:4 Changed 13 years ago by David Loeffler

Authors: Nick Alexander
Merged in: 4.0.alpha0
Reviewers: William Stein
Note: See TracTickets for help on using tickets.