Opened 14 years ago

Closed 14 years ago

#6011 closed enhancement (fixed)

[with patch, positive review] Bring plot/arrow.py to 100% coverage

Reported by: Karl-Dieter Crisman Owned by: Karl-Dieter Crisman
Priority: minor Milestone: sage-4.0
Component: documentation Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Bring plot/arrow.py to 100% coverage

Attachments (2)

trac_6011.patch (9.3 KB) - added by Karl-Dieter Crisman 14 years ago.
trac_6011-reviewer.patch (1.6 KB) - added by Minh Van Nguyen 14 years ago.
reviewer patch; add consistency to the whole module

Download all attachments as: .zip

Change History (7)

Changed 14 years ago by Karl-Dieter Crisman

Attachment: trac_6011.patch added

comment:1 Changed 14 years ago by Karl-Dieter Crisman

Owner: changed from Michael Abshoff to Karl-Dieter Crisman
Status: newassigned
Summary: Bring plot/arrow.py to 100% coverage[with patch, needs review] Bring plot/arrow.py to 100% coverage

Also adds tiny plot3d enhancement (original doctest only tested Graphics.plot3d).

Please see http://groups.google.com/group/sage-devel/browse_thread/thread/1adac4035031b140/c36f1f8a7c8a9b43#c36f1f8a7c8a9b43 for why there is no loads(dumps()) test. Yet.

comment:2 Changed 14 years ago by Karl-Dieter Crisman

Component: doctestdocumentation

Changed 14 years ago by Minh Van Nguyen

Attachment: trac_6011-reviewer.patch added

reviewer patch; add consistency to the whole module

comment:3 Changed 14 years ago by Minh Van Nguyen

REFEREE REPORT

The patch trac_6011.patch applies OK against the "post-final" version sage-3.4.2, all doctests pass with the options -t -long, and the doctest coverage is now 100% as claimed. Note that sage/plot/arrow.py is not included in the reference manual, so you can't search for it in order to view the documentation for sage/plot/arrow.py.

The patch adds some trivial inconsistencies in how "two-dimensional" and "three-dimensional" are abbreviated. These and other inconsistencies are fixed in the reviewer patch trac_6011-reviewer.patch. Apart from the issue of consistency throughout the whole module, positive review for kcrisman's patch. Only my patch needs to be reviewed.

comment:4 Changed 14 years ago by John Palmieri

Summary: [with patch, needs review] Bring plot/arrow.py to 100% coverage[with patch, positive review] Bring plot/arrow.py to 100% coverage

comment:5 Changed 14 years ago by Michael Abshoff

Resolution: fixed
Status: assignedclosed

Merged both patches in Sage 4.0.alpha0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.