Opened 10 years ago

Closed 7 years ago

#6003 closed enhancement (worksforme)

Additions to Cholesky decomposition

Reported by: rbeezer Owned by: rbeezer
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: linear algebra Keywords:
Cc: ncalexan Merged in:
Authors: Reviewers: Rob Beezer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

These are enhancements to #5554, which have been split off here. Numbering is the same. See #5554 for more details

  1. Make a positive-definite check the default, with a keyword to turn it off.
  1. Minor improvements to the docstrings.
  1. Warnings about accuracy for generic algorithm.

Change History (5)

comment:1 Changed 7 years ago by dsm

  • Report Upstream set to N/A

Is this still valid given the positively reviewed #13035 and the pending #11274?

comment:2 follow-up: Changed 7 years ago by rbeezer

  • Status changed from new to needs_review

Thanks, Doug. Yes I think this has exceeded its shelf-life. The referenced tickets (and maybe one or two others) basically put Cholesky decomposition on a firm footing again.

I'll try to put this into the right status to get Jeroen's attention.

Release Manager

This can be safely marked "wontfix" or made obsolete in some other way. Thanks.

comment:3 Changed 7 years ago by rbeezer

  • Status changed from needs_review to positive_review

comment:4 in reply to: ↑ 2 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-feature to sage-duplicate/invalid/wontfix
  • Reviewers set to Rob Beezer

Replying to rbeezer:

Thanks, Doug. Yes I think this has exceeded its shelf-life. The referenced tickets (and maybe one or two others) basically put Cholesky decomposition on a firm footing again.

I'll try to put this into the right status to get Jeroen's attention.

Just for your information: it's better to also change the milestone the sage-duplicate/invalid/wontfix.

comment:5 Changed 7 years ago by jdemeyer

  • Resolution set to worksforme
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.