Opened 10 years ago

Closed 10 years ago

#5953 closed defect (fixed)

[with patch, positive review] sage/modular/modform/vm_basis.py is missing verbatim areas for doctests

Reported by: mabshoff Owned by: mabshoff
Priority: major Milestone: sage-3.4.2
Component: documentation Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This is what the ReST documentation looks like:

EXAMPLES:
sage: victor_miller_basis(1, 6) [] sage: victor_miller_basis(0, 6) [ 1 + O(q^6) ] sage: victor_miller_basis(2, 6) [] sage: victor_miller_basis(4, 6) [ 1 + 240*q + 2160*q^2 + 6720*q^3 + 17520*q^4 + 30240*q^5 + O(q^6) ]

sage: victor_miller_basis(6, 6, var=’w’) [ 1 - 504*w - 16632*w^2 - 122976*w^3 - 532728*w^4 - 1575504*w^5 + O(w^6) ]

Cheers,

Michael

Attachments (2)

trac_5953.patch (2.4 KB) - added by mabshoff 10 years ago.
ref_5953.patch (1.9 KB) - added by jhpalmieri 10 years ago.
referee's patch

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by mabshoff

comment:1 Changed 10 years ago by jhpalmieri

  • Summary changed from sage/modular/modform/vm_basis.py is missing verbatim areas for doctests to [with patch, positive review] sage/modular/modform/vm_basis.py is missing verbatim areas for doctests

I think that in INPUT and AUTHOR blocks, the lines shouldn't be indented. I'm attaching a referee's patch changing this, and also changing an instance of $blah$ to `blah`. If you're happy with my patch, I'm happy with yours.

Changed 10 years ago by jhpalmieri

referee's patch

comment:2 Changed 10 years ago by mabshoff

For the record: Reviewer patch looks good to me.

Cheers,

Michael

comment:3 Changed 10 years ago by mabshoff

  • Milestone changed from sage-4.0 to sage-3.4.2
  • Owner changed from tba to mabshoff
  • Status changed from new to assigned

comment:4 Changed 10 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged both patches in Sage 3.4.2.final.

Cheers,

Michael

Note: See TracTickets for help on using tickets.