Opened 10 years ago

Closed 5 years ago

#5903 closed task (fixed)

Remove dist directories from Sage distribution

Reported by: tabbott Owned by: tabbott
Priority: major Milestone: sage-6.1
Component: packages: standard Keywords: sd32
Cc: leif Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: u/jdemeyer/ticket/5903 (Commits) Commit: d9ce2855c33e3ccd310963a4862fbef72fc6c2be
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

The dist/ directories currently shipped in various Sage .spkg's are no longer used and should be removed. The list of packages needing this treatment is:

  • rubiks

Change History (23)

comment:1 Changed 10 years ago by ddrake

As part of #7005, I'll ask that the dist/ be removed from the Singular spkg.

comment:2 Changed 9 years ago by mvngu

  • Description modified (diff)
  • Report Upstream set to N/A

Ticket #7109 removes "dist/" from cddlib.

comment:3 Changed 9 years ago by mvngu

  • Description modified (diff)

Ticket #7820 removes "dist/" from gfan.

comment:4 follow-up: Changed 9 years ago by leif

  • Cc leif added

I've "informed" the Tachyon and the (three) Lcalc upgrade/update tickets...

Some of the packages in the list have meanwhile been upgraded or updated; I'm not sure which of them actually removed the dist/ directory. (I think I did in the M4RI and/or PolyBoRi spkgs.)

comment:5 in reply to: ↑ 4 Changed 9 years ago by leif

Replying to leif:

I've "informed" the Tachyon and the (three) Lcalc upgrade/update tickets...

And that of genus2reduction (#9591).

comment:6 Changed 9 years ago by mvngu

Ticket #9562 removes dist/ from libm4ri.

comment:7 Changed 9 years ago by mvngu

  • Description modified (diff)

comment:8 Changed 8 years ago by vbraun

Ticket #5281 removes the dist directory from tachyon.

comment:9 Changed 8 years ago by mariah

  • Description modified (diff)

Code to identify packages with dist directory

#!/usr/bin/python

# search spkgs for dist directory 
#
# assumes you start in spkg/standard

import sys,os,subprocess

cur = os.getcwd()
print cur

for filename in os.listdir("."):
  if filename.endswith(".spkg"):
    val = subprocess.check_output(["file", filename])
    if val.find("bzip2") > -1:
      basename=filename.rstrip(".spkg")
      subprocess.check_output(["cp", filename,basename +".tar.bz2"])
      subprocess.check_output(["bunzip2", basename + ".tar.bz2"])
    else: # fortran.spkg (only tar'ed) 
      basename=filename.rstrip(".spkg")
      subprocess.check_output(["cp", filename,basename + ".tar"])
    subprocess.check_output(["tar", "xf", basename + ".tar"])
    if os.path.exists(cur + "/" + basename + "/dist") == True:
      print filename

comment:10 Changed 8 years ago by mariah

  • Description modified (diff)

comment:11 Changed 8 years ago by mariah

  • Milestone changed from sage-4.7 to sage-4.7.1

comment:12 Changed 8 years ago by was

  • Keywords sd32 added

comment:13 Changed 7 years ago by jdemeyer

  • Component changed from debian-package to packages

comment:14 Changed 7 years ago by jdemeyer

  • Description modified (diff)

comment:15 Changed 7 years ago by leif

  • Description modified (diff)

comment:16 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:17 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:18 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/5903
  • Modified changed from 08/13/13 15:35:53 to 08/13/13 15:35:53

comment:19 Changed 5 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to 552a4261eaede3b0051d20ed185e01849f440c4d
  • Status changed from new to needs_review

New commits:

25b0e43Allow specifying files to be checksummed
552a426Remove rubiks/dist directory

comment:20 Changed 5 years ago by git

  • Commit changed from 552a4261eaede3b0051d20ed185e01849f440c4d to d9ce2855c33e3ccd310963a4862fbef72fc6c2be

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d9ce285Remove rubiks/dist directory

comment:21 Changed 5 years ago by chapoton

  • Status changed from needs_review to positive_review

Ok, this is indeed the last one where dist still exists. Good enough for me.

comment:22 Changed 5 years ago by vbraun

  • Reviewers set to Frédéric Chapoton

fill in the reviewer field...

comment:23 Changed 5 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.