Changes between Version 18 and Version 19 of Ticket #5891


Ignore:
Timestamp:
11/10/09 10:46:42 (9 years ago)
Author:
nthiery
Comment:

Replying to was:

NOTES:

(1) Post the latest version here -- I don't want to mess with the patch server.

I just added direct links in the description. I will post the patches shortly when they will be final.

(2) It says "Experts: please redefine this properly and/or put CC/RR/... in NumberFields?()". I number field is by definition a finite extension of QQ, but CC and RR are infinite extensions of QQ. So we can't put them in that category. Having a function is_NumberFieldHomsetCodomain does seem like a good workaround for now.

Ok.

(3) The function is_NumberFieldHomsetCodomain in the patch posted here doesn't have any documentation or doctests. Please add them.

Oops. Will do.

(4) (5) (6)

Yes better. Will do.

(6) I'm puzzled by this in your number_field_rel.py patch: 

	543	            return NotImplemented

What is NotImplemented?? It's not defined in the number_field_rel.py file in sage-4.2.

It's a builtin python object. Anyway, the function now raises a TypeError?, per the latest _Hom_ protocol.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #5891

    • Property Status changed from needs_work to needs_review
    • Property Authors changed from to Nicolas M. Thiéry
    • Property Reviewers changed from to Robert Bradshaw, Florent Hivert, David Kohel, David Roe, Anne Schilling, Javier Vengoroso

  • Ticket #5891 – Description

    v18 v19  
    99   updates to the sage library (import fixes, ...)
    1010   - [http://combinat.sagemath.org/patches/file/tip/categories-fix-combinat-nt.patch]       (positive review: Florent)
    11    - [http://combinat.sagemath.org/patches/file/tip/categories-numberfield_homset-nt.patch] (reviewer: David)
     11   - [http://combinat.sagemath.org/patches/file/tip/categories-numberfieldvengoroso_homset-nt.patch] (reviewer: David)
    1212   - [http://combinat.sagemath.org/patches/file/tip/categories-unpickle_backward_compatibility_aliases-nt.patch] (positive review: Florent)
    1313