Opened 12 years ago

Closed 12 years ago

#5872 closed defect (fixed)

[with patch, positive review] Explicitly pass -fPIC into ntl shared object build.

Reported by: pjeremy Owned by: mhansen
Priority: major Milestone: sage-4.1
Component: porting: BSD Keywords:
Cc: Merged in: sage-4.1.rc0
Authors: Peter Jeremy Reviewers: Mike Hansen
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The ntl makefile appears to rely on compiler flags specified as a target dependency being passed to the compiler. This fails on at least FreeBSD, resulting in an attempt to include non-PIC objects in a shared library.

Instead, explicitly pass -fPIC to the sub-make used for the shared object build.

Attachments (1)

ntl-5.4.2.p6.patch​ (562 bytes) - added by pjeremy 12 years ago.

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by pjeremy

comment:1 Changed 12 years ago by mhansen

  • Authors set to Peter Jeremy
  • Owner changed from mabshoff to mhansen
  • Reviewers set to Mike Hansen
  • Status changed from new to assigned
  • Summary changed from [with patch, needs review] Explicitly pass -fPIC into ntl shared object build. to [with patch, positive review] Explicitly pass -fPIC into ntl shared object build.

Looks good to me.

The spkg incorporating this patch can be found at ​http://sage.math.washington.edu/home/mhansen/ntl-5.4.2.p8.spkg

comment:2 Changed 12 years ago by rlm

  • Merged in set to sage-4.1.rc0
  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.