Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#5866 closed defect (fixed)

[with patch, positive review] Fix freetype build on systems where make is not GNU make.

Reported by: pjeremy Owned by: mhansen
Priority: major Milestone: sage-4.1
Component: porting: BSD Keywords:
Cc: Merged in: sage-4.1.rc0
Authors: Peter Jeremy Reviewers: Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Change 'make' to ${MAKE} - is the recommended way to recursively invoke make to ensure that the subordinate make is the same as the parent make (and also ensures that the two make instances will communicate on things like '-jX').

Explicitly export the parent make into the configure script.

These changes avoid problems on systems like FreeBSD where make is not GNU make.

Attachments (1)

freetype-2.3.5.p0.patch (441 bytes) - added by pjeremy 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by pjeremy

comment:1 Changed 12 years ago by mabshoff

  • Milestone set to sage-3.4.2
  • Summary changed from Fix freetype build on systems where make is not GNU make. to [with patch, needs review] Fix freetype build on systems where make is not GNU make.

I will work on integrating this tomorrow.

Cheers,

Michael

comment:2 Changed 12 years ago by mhansen

  • Authors set to Peter Jeremy
  • Owner changed from mabshoff to mhansen
  • Reviewers set to Mike Hansen
  • Status changed from new to assigned
  • Summary changed from [with patch, needs review] Fix freetype build on systems where make is not GNU make. to [with patch, positive review] Fix freetype build on systems where make is not GNU make.

Looks good to me.

The spkg with this change incorporated can be found at http://sage.math.washington.edu/home/mhansen/freetype-2.3.5.p1.spkg

comment:3 Changed 12 years ago by rlm

  • Merged in set to sage-4.1.rc0
  • Resolution set to fixed
  • Status changed from assigned to closed

comment:4 Changed 11 years ago by drkirkby

  • Report Upstream set to N/A

I'll create a new ticket for this issue, but I thought it useful to add to this ticket.

I tried to update freetype to the latest version (2.3.12), but the build fails with:

libtool: link: (cd "/export/home/drkirkby/32/sage-4.4.3/spkg/build/freetype-2.3.12/src/objs/.libs" && rm "libfreetype.so.6" && ln -s "libfreetype.so.6.4.0" "libfreetype.so.6")
libfreetype.so.6: No such file or directory
make: *** [/export/home/drkirkby/32/sage-4.4.3/spkg/build/freetype-2.3.12/src/objs/libfreetype.la] Error 2

real    3m16.562s
user    2m54.021s
sys     0m22.112s
sage: An error occurred while installing freetype-2.3.12

Changing spkg-install to

if [ "x`uname`" != xSunOS ] ; then 
   GNUMAKE=${MAKE} ./configure --prefix="$SAGE_LOCAL"
else
  ./configure --prefix="$SAGE_LOCAL"
fi

allows the latest freetype to build on Solaris 10 on SPARC.

comment:5 Changed 11 years ago by drkirkby

I should have added that 'make' is a version of GNU make on Solaris, as Sun's make will never build Sage. The MAKE environment variable was not set.

Dave

Note: See TracTickets for help on using tickets.