Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#5864 closed enhancement (fixed)

Correctly inherit build environment in eclib

Reported by: pjeremy Owned by: mhansen
Priority: minor Milestone: sage-4.5
Component: porting: BSD Keywords:
Cc: Merged in:
Authors: Peter Jeremy Reviewers: Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Change 'make' to ${MAKE} - is the recommended way to recursively invoke make to ensure that the subordinate make is the same as the parent make (and also ensures that the two make instances will communicate on things like '-jX').

Explicitly use gmake instead of make on FreeBSD.

Attachments (1)

eclib-20080310.p7.patch (937 bytes) - added by pjeremy 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by pjeremy

comment:1 Changed 12 years ago by mabshoff

  • Milestone set to sage-3.4.2
  • Summary changed from Correctly inherit build environment in eclib to [with patch, needs review] Correctly inherit build environment in eclib

comment:2 Changed 12 years ago by mhansen

  • Authors set to Peter Jeremy
  • Owner changed from mabshoff to mhansen
  • Reviewers set to Mike Hansen
  • Status changed from new to assigned
  • Summary changed from [with patch, needs review] Correctly inherit build environment in eclib to [with patch, positive review] Correctly inherit build environment in eclib

Looks good to me.

The spkg with this patch incorporated can be found at http://sage.math.washington.edu/home/mhansen/eclib-20080310.p8.spkg

comment:3 Changed 12 years ago by cremona

  • Summary changed from [with patch, positive review] Correctly inherit build environment in eclib to [with patch, with review, needs work] Correctly inherit build environment in eclib

I am confused here. I already have a .p8 version, dated 2009-01-07. Now you have created a new .p8 which must be different!

Checking the SPKG.txt in my p8 I see this entry:

eclib-20080310.p8 (John Cremona, January 6th, 2009)

  • Change to debugging output in procs/p2points.cc (not relevant for Sage)
  • Change to pdivs() in procs/marith.cc (not relevant for Sage)

I suggest that we syncronise, otherwise I will get even more confused. For a start, this ticket should have had me in its CC list! I don't see how I can be expected to be responsible for this spkg if people are changing it without even telling me!

Hence I have changed this back to "needs work".

comment:4 Changed 11 years ago by pjeremy

  • Report Upstream set to N/A
  • Resolution set to fixed
  • Status changed from needs_work to closed

This ticket is no longer needed with eclib-20080310.p10

comment:5 Changed 11 years ago by mvngu

  • Summary changed from [with patch, with review, needs work] Correctly inherit build environment in eclib to Correctly inherit build environment in eclib
Note: See TracTickets for help on using tickets.