Opened 12 years ago
Closed 12 years ago
#5853 closed defect (fixed)
[with patch, with positive review] Restify and include more documentation on elliptic curves
Reported by: | wuthrich | Owned by: | was |
---|---|---|---|
Priority: | major | Milestone: | sage-3.4.2 |
Component: | number theory | Keywords: | documentation, elliptic curves |
Cc: | cremona | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Attachments (4)
Change History (9)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
No no, this patch is not right, do not even look at it. Sorry!!!!
Changed 12 years ago by
comment:3 Changed 12 years ago by
- Description modified (diff)
- Summary changed from Restify and include more documentation on elliptic curves to [with patch, needs review] Restify and include more documentation on elliptic curves
What do we learn : never try to submit a patch just before catching the train. Sorry about this patching mess.
Only the very last patch counts. I applied it successfully against 3.4.1 + #4933 and #5851. It produces three doctest-errors in ell_rational_field with --long, but they are there even without my patch it seems to me.
One might decide against including ell_modular_symbols. The main documentation is in ell_rational_field. Of course I did not include padic_height, since it is deprecated anyway.
I do not know how to solve the issue of the alias power_series producing double documentation. I do not know how the references to article should be done correctly.
comment:4 Changed 12 years ago by
- Summary changed from [with patch, needs review] Restify and include more documentation on elliptic curves to [with patch, with positive review] Restify and include more documentation on elliptic curves
Great work! The patch trac_5853_2.patch applies fine to 3.4.2.alpha0. There a docbuild glitch in ell_rational_field.py which has nothing to do with this patch. The new sections in the manual look great. All doctests in elliptic_curves pass (as of course they should since this patch only touches docstring, apart from a few very small things).
comment:5 Changed 12 years ago by
- Milestone changed from sage-4.0 to sage-3.4.2
- Resolution set to fixed
- Status changed from new to closed
Merged trac_5853_2.patch in Sage 3.4.2.rc0.
Cheers,
Michael
Very good! Nice to know I have been setting a good example.
Chris, in case you have not yet picked this up, debugging the restification involves the following.
Not all of that was obvious to me, so I hope it helps!