Opened 12 years ago

Closed 12 years ago

#5853 closed defect (fixed)

[with patch, with positive review] Restify and include more documentation on elliptic curves

Reported by: wuthrich Owned by: was
Priority: major Milestone: sage-3.4.2
Component: number theory Keywords: documentation, elliptic curves
Cc: cremona Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by wuthrich)

This is a follow-up on ticket #4933 and #5851. I plan to work on following files

  • ell_modular_symbols.py
  • ell_tate_curve.py
  • padic_lseries.py
  • sha_tate.py

Attachments (4)

trac_5853.patch (76.4 KB) - added by wuthrich 12 years ago.
to be applied after tickets in #5846 and #5851
trac_5846_prec_2.patch (867 bytes) - added by wuthrich 12 years ago.
Replaces the previous ticket as before this applies to 3.4.1 + #5846 and #5851
trac_5846_prec_2.2.patch (867 bytes) - added by wuthrich 12 years ago.
replaces all before.
trac_5853_2.patch (77.1 KB) - added by wuthrich 12 years ago.
replaces all before

Download all attachments as: .zip

Change History (9)

comment:1 Changed 12 years ago by cremona

Very good! Nice to know I have been setting a good example.

Chris, in case you have not yet picked this up, debugging the restification involves the following.

  1. Make a new clone.
  2. In the new clone run "sage -docbuild reference html". The first time takes a while.
  3. Point your browser at the place it says (prepend "file://" and append "index.html")
  4. If you are adding a new file to the ref manual, add a suitable line to (for example) $SAGE_ROOT/devel/sage/doc/en/reference/plane_curves.rst
  5. After making some edits, after doing "sage -b" then as well as doing "sage -t" on the file, also do (again) "sage -docbuild reference html" which will pick up that the file has changed and rebuild the html page. Of course the page needs to be reloaded in the browser.

Not all of that was obvious to me, so I hope it helps!

Changed 12 years ago by wuthrich

to be applied after tickets in #5846 and #5851

comment:2 Changed 12 years ago by wuthrich

No no, this patch is not right, do not even look at it. Sorry!!!!

Changed 12 years ago by wuthrich

Replaces the previous ticket as before this applies to 3.4.1 + #5846 and #5851

Changed 12 years ago by wuthrich

replaces all before.

Changed 12 years ago by wuthrich

replaces all before

comment:3 Changed 12 years ago by wuthrich

  • Description modified (diff)
  • Summary changed from Restify and include more documentation on elliptic curves to [with patch, needs review] Restify and include more documentation on elliptic curves

What do we learn : never try to submit a patch just before catching the train. Sorry about this patching mess.

Only the very last patch counts. I applied it successfully against 3.4.1 + #4933 and #5851. It produces three doctest-errors in ell_rational_field with --long, but they are there even without my patch it seems to me.

One might decide against including ell_modular_symbols. The main documentation is in ell_rational_field. Of course I did not include padic_height, since it is deprecated anyway.

I do not know how to solve the issue of the alias power_series producing double documentation. I do not know how the references to article should be done correctly.

comment:4 Changed 12 years ago by cremona

  • Summary changed from [with patch, needs review] Restify and include more documentation on elliptic curves to [with patch, with positive review] Restify and include more documentation on elliptic curves

Great work! The patch trac_5853_2.patch applies fine to 3.4.2.alpha0. There a docbuild glitch in ell_rational_field.py which has nothing to do with this patch. The new sections in the manual look great. All doctests in elliptic_curves pass (as of course they should since this patch only touches docstring, apart from a few very small things).

comment:5 Changed 12 years ago by mabshoff

  • Milestone changed from sage-4.0 to sage-3.4.2
  • Resolution set to fixed
  • Status changed from new to closed

Merged trac_5853_2.patch in Sage 3.4.2.rc0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.