Opened 10 years ago

Closed 10 years ago

#5848 closed defect (fixed)

[with patch, positive review] untabify Sage

Reported by: jhpalmieri Owned by: jhpalmieri
Priority: minor Milestone: sage-3.4.2
Component: misc Keywords:
Cc: roed Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The attached patch removes all of the TABs I could find in .py and .pyx files in the Sage library.

Attachments (2)

untabify.patch (222.1 KB) - added by jhpalmieri 10 years ago.
trac_5848_untabify.patch (218.9 KB) - added by mabshoff 10 years ago.
John's patch with the changes for three no longer existing files removed.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by jhpalmieri

comment:1 Changed 10 years ago by rbeezer

  • Summary changed from [with patch, needs review] untabify Sage to [with patch, positive review] untabify Sage

Patch choked twice on modular/dirichlet.py, which seems odd, given how fresh it is, and I can't really tell why. I was applying it to an upgraded 3.4.1.rc4 Maybe it will patch better under mabshoff's firm guidance.

Builds just fine. Passes sage -testall, except some unpickling errors in structure/sage_object.pyx and algebras/quaternion_algebra_element.py concerning QuaternionAlgebraElements, but the changes to these files don't appear implicated in these errors,

Documentation builds fine as well (PDF of reference manual) with no TeX errors.

Positive review, subject to the business above about patching modular/dirichlet.py.

comment:2 follow-up: Changed 10 years ago by mabshoff

I am not sure which rejects Rob saw, but it is applying fine for me.

Cheers,

Michael

comment:3 in reply to: ↑ 2 Changed 10 years ago by rbeezer

Replying to mabshoff:

I am not sure which rejects Rob saw, but it is applying fine for me.

Superior Merge-Fu. ;-)

comment:4 Changed 10 years ago by mabshoff

  • Cc roed added

Ok, the patch still applies modulo three the diff for three files

  • sage/algebras/algebra_order.py
  • sage/algebras/algebra_order.py
  • sage/algebras/algebra_order_ideal.py

that no longer exist. This patch besides the latex one I just merged at #5610 has high risks for rejects, but since I merged the other one I might as well merge this one.

David: Some of the padics files are touched, so if you rebase your patch bomb in the morning please also apply the patch I will post in a minute.

Cheers,

Michael

Changed 10 years ago by mabshoff

John's patch with the changes for three no longer existing files removed.

comment:5 Changed 10 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged trac_5848_untabify.patch in Sage 3.4.2.alpha0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.