Opened 10 years ago

Closed 10 years ago

#5846 closed defect (fixed)

[with patch, positive review] small bug in caching the precision for p-adic L-series

Reported by: wuthrich Owned by: was
Priority: minor Milestone: sage-3.4.2
Component: number theory Keywords: p-adic L-series
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

When looking up cached values of the p-adic L-series of an elliptic curve, there is a problem with the precision (as a powe-series in T) :

sage: E = EllipticCurve('389a')
sage: p = 3
sage: L = E.padic_lseries(p)
sage: L.series(3)
O(3^5) + O(3^2)*T + (2 + 2*3 + O(3^2))*T^2 + (2 + O(3))*T^3 + (1 + 3 + O(3^2))*T^4 + O(T^5)
sage: L.series(3,prec=6)
O(3^5) + O(3^2)*T + (2 + 2*3 + O(3^2))*T^2 + (2 + O(3))*T^3 + (1 + 3 + O(3^2))*T^4 + O(T^5)

The attached patch changes the inequality sign in question.

Attachments (3)

trac_5846_prec.patch (2.4 KB) - added by wuthrich 10 years ago.
trac_5846_prec_2.patch (867 bytes) - added by wuthrich 10 years ago.
to apply after the first patch
trac_5846_combined.patch (1.5 KB) - added by GeorgSWeber 10 years ago.
apply only this one

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by wuthrich

comment:1 Changed 10 years ago by wuthrich

  • Summary changed from small bug in caching the precision for p-adic L-series to [with patch, needs review] small bug in caching the precision for p-adic L-series

comment:2 Changed 10 years ago by mabshoff

One slight nitpick: The trac number in the patch is missing.

Cheers,

Michael

comment:3 Changed 10 years ago by mabshoff

  • Milestone changed from sage-3.4.1 to sage-3.4.2

And this is not going into 3.4.1 since it is basically done, so better luck in 3.4.2 :)

Cheers,

Michael

Changed 10 years ago by wuthrich

to apply after the first patch

comment:4 Changed 10 years ago by wuthrich

I added the forgotten trac number in the doctest.

Chris.

Changed 10 years ago by GeorgSWeber

apply only this one

comment:5 Changed 10 years ago by GeorgSWeber

  • Summary changed from [with patch, needs review] small bug in caching the precision for p-adic L-series to [with patch, positive review] small bug in caching the precision for p-adic L-series

The first two hunks of the first patch didn't apply to sage-3.4.2.alpha0, but they contained only whitespace beautification. Probably this had already been adressed. I merged the remaining two hunks with the "real" patch and the the second patch. Ready to go.

comment:6 Changed 10 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged trac_5846_combined.patch in Sage 3.4.2.rc0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.