Opened 8 years ago

Closed 8 years ago

#5783 closed defect (fixed)

[with patch, positive review] Lazy attribute fixes and improvements

Reported by: nthiery Owned by: nthiery
Priority: major Milestone: sage-4.0
Component: misc Keywords:
Cc: sage-combinat Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by nthiery)

  • fix infinite recursion bug
  • adds support for cpdefs methods
  • fix ReST doc (indentation, ::, ...)
  • fix introspection (hopefuly)
  • adds a hook for this in sage.misc.sageinspect.sage_getsourcelines

Attachments (1)

lazy_attributes-fixes-5783-final.patch​ (22.2 KB) - added by nthiery 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by mabshoff

  • Milestone set to sage-combinat

comment:2 Changed 8 years ago by nthiery

  • Owner changed from cwitty to nthiery

Changed 8 years ago by nthiery

comment:3 Changed 8 years ago by nthiery

  • Description modified (diff)
  • Status changed from new to assigned
  • Summary changed from [with patch, needs review] Lazy attributes: fix infinite recursion bug + support for cpdefs methods to [with patch, needs review] Lazy attribute fixes and improvements

comment:4 Changed 8 years ago by nthiery

  • Description modified (diff)

Updated patch:

  • fix ReST doc (indentation, ::, ...)
  • fix introspection
  • adds a hook for this in sage.misc.sageinspect.sage_getsourcelines

comment:5 Changed 8 years ago by roed

Adds lots of good documentation, fixes some problems, though additional feature requests remain. Positive review.

comment:6 Changed 8 years ago by mabshoff

  • Summary changed from [with patch, needs review] Lazy attribute fixes and improvements to [with patch, positive review] Lazy attribute fixes and improvements

David,

please remember to change the summary if you do reviews of tickets.

Michael

comment:7 Changed 8 years ago by mabshoff

  • Milestone changed from sage-combinat to sage-4.0
  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 4.0.rc0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.