Opened 12 years ago
Closed 12 years ago
#5777 closed defect (fixed)
[with package and patches, positive review] update to pynac 0.1.6
Reported by: | burcin | Owned by: | mhansen |
---|---|---|---|
Priority: | major | Milestone: | sage-4.0 |
Component: | symbolics | Keywords: | |
Cc: | wstein, mhansen, ncalexan, robertwb | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
There is a new version of pynac with the following changes:
- Change printing of pi (Pi -> pi)
- Delay evaluation of special functions until .evalf() is called
- Add precision parameter to .evalf()
I am opening a new ticket, since the patches require separate review.
The package is here:
http://sage.math.washington.edu/home/burcin/pynac/pynac-0.1.5.spkg
Attached patches need to be applied to Sage, they depend on #5753.
I got an infinite loop trying to convert to ComplexField
in the second patch, hence the additions to sage/rings/complex_field.py. Robert, am I doing something wrong here?
Attachments (7)
Change History (11)
Changed 12 years ago by
comment:1 Changed 12 years ago by
Rebased attachment:trac_5777-02-precision.patch for 3.4.1.
comment:2 Changed 12 years ago by
- Summary changed from [with package and patches, needs review] update to pynac 0.1.5 to [with package and patches, needs review] update to pynac 0.1.6
I put a preliminary version of the new pynac package here:
http://sage.math.washington.edu/home/burcin/pynac/pynac-0.1.6.spkg
I haven't actually committed the version information to the pynac repository yet. I plan to wait until this gets reviewed, and see if there are any last minute changes needed.
The newly uploaded patches:
- attachment:trac_5777-11-hash_doctests.patch
- attachment:trac_5777-12-pickle_expression.patch
- attachment:trac_5777-13-pickle_sfunction.patch
- attachment:trac_5777-14-exp.patch
correspond to the changes in the new package.
The changes in pynac are:
- Fix error handling in Number_T::hash().
- Add support for archiving numeric and function objects.
- Fix comparison bug in mul.
- Fix gcc warnings about conversion of strings to char*.
- Change exp to not prints exponents of 1.
- Add power method to exp so that
(e^x)^y -> e^(x*y)
.
Note that this fixes #5944, which I consider a blocker.
comment:3 Changed 12 years ago by
- Owner changed from burcin to mhansen
- Status changed from new to assigned
- Summary changed from [with package and patches, needs review] update to pynac 0.1.6 to [with package and patches, positive review] update to pynac 0.1.6
I have all of Burcin's changes that apply to 4.0.rc0 in symbolics_final1.patch. These work with the pynac-0.1.6.spkg.
These get a positive review from me. I've based the new symbolics changes on these.
Changed 12 years ago by
comment:4 Changed 12 years ago by
- Milestone changed from sage-4.0.1 to sage-4.0
- Resolution set to fixed
- Status changed from assigned to closed
Merged in Sage 4.0.rc0.
Cheers,
Michael
fix doctests for printing changes