Opened 11 years ago

Closed 11 years ago

#5770 closed defect (fixed)

[with patch, positive review] Bring doctests of modular/modsym/p1list.py up to 100%

Reported by: cremona Owned by: craigcitro
Priority: major Milestone: sage-3.4.1
Component: modular forms Keywords: modular form documentation
Cc: davidloeffler Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The attached patch completes all docstrings and doctests for the file modular/modsym/p1list.py. I also checked that the html and pdf output in the reference manual look good.

Attachments (2)

p1list-doc.patch (29.3 KB) - added by cremona 11 years ago.
Based on 3.4.1.rc2
trac_5770-reviewer_fix.patch (724 bytes) - added by davidloeffler 11 years ago.
apply over previous patch

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by cremona

Based on 3.4.1.rc2

comment:1 Changed 11 years ago by davidloeffler

  • Cc davidloeffler added

comment:2 Changed 11 years ago by davidloeffler

  • Summary changed from [with patch, needs review] Bring doctests of modular/modsym/p1list.py up to 100% to [with patch, positive review] Bring doctests of modular/modsym/p1list.py up to 100%

Patch applies fine to 3.4.1.rc2, all doctests pass, and reference manual builds happily. There is just one tiny typo: in the docstring for "apply_S", it has "[-0,1;1,0]" instead of "[0,-1;1,0]". I have uploaded a patch that corrects this.

Changed 11 years ago by davidloeffler

apply over previous patch

comment:3 Changed 11 years ago by cremona

Thanks, David. Getting the documentation to build & look ok takes a long time! As you can imagine there was a lot of cutting and pasting. Much more of the same to com with manin_symbols.py, where there are about 5 classes each of which has a very similar set of methods (but not quite identical).

comment:4 Changed 11 years ago by mabshoff

  • Milestone changed from sage-3.4.2 to sage-3.4.1
  • Resolution set to fixed
  • Status changed from new to closed

Merged both patches in Sage 3.4.1.rc3.

Cheers,

Michael

Note: See TracTickets for help on using tickets.