Opened 12 years ago

Closed 8 years ago

#5763 closed defect (invalid)

[with patch, needs work] pynac -- add _polynomial_ conversion constructor

Reported by: ncalexan Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: symbolics Keywords: pynac symbolics _polynomial_ constructor
Cc: burcin, mhansen, was Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The attached patch adds conversion to polynomial rings. Two doctests fail at this time; they rely on being able to convert to CDF and ComplexField?(100). I didn't want them to get forgotten so I left them in.

Attachments (1)

trac_5763-symbolic-polynomial.patch (12.5 KB) - added by ncalexan 12 years ago.

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by ncalexan

comment:1 Changed 12 years ago by burcin

Thanks Nick!

The patch looks great, I am looking at the doctests right now.

Note that #5753 fixes the coercion of constants to pynac, so you can use is_a_constant in the .is_constant() function.

I will see what I can do about the doctest failures, and hopefully post a patch fixing them soon.

comment:2 Changed 12 years ago by ncalexan

In fact, you can make the doctest works by changing the if is_constant check to coerce the pyobject in. It's a one line fix that I haven't posted here, it works well for me in practice.

comment:3 Changed 12 years ago by burcin

  • Cc was added
  • Milestone changed from sage-4.0.1 to sage-4.0

This patch seems to have been forgotten during the "pynac push." I recall that it was briefly mentioned on IRC once.

I suggest closing this issue as wontfix now. Trac doesn't allow me close tickets any more.

comment:4 Changed 12 years ago by was

  • Milestone changed from sage-4.0 to sage-4.0.1

This isn't critical for 4.0.

comment:5 Changed 12 years ago by mvngu

The docstring should adhere to ReST formatting. Some examples follow this rule, but most don't. I'm merely enforcing proper ReST formatting, not actually reviewing the whole patch.

comment:6 Changed 12 years ago by boothby

  • Summary changed from [with patch, needs review] pynac -- add _polynomial_ conversion constructor to [with patch, needs work] pynac -- add _polynomial_ conversion constructor

This should have been marked as a negative review.

comment:7 Changed 8 years ago by mhansen

  • Milestone changed from sage-5.11 to sage-duplicate/invalid/wontfix
  • Report Upstream set to N/A
  • Resolution set to invalid
  • Status changed from needs_work to closed

I think we can close this as invalid as all of the doctests in the patch currenly pass.

Note: See TracTickets for help on using tickets.