Opened 14 years ago

Closed 14 years ago

#5760 closed defect (fixed)

[with patch, positive review] bring doctest coverage of plot3d/shapes.pyx to 100%

Reported by: robertwb Owned by: mabshoff
Priority: major Milestone: sage-3.4.1
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

plot/plot3d/shapes.pyx: 16% (5 of 31)

Attachments (1)

5760-shapes-doctests.patch (25.8 KB) - added by robertwb 14 years ago.

Download all attachments as: .zip

Change History (4)

Changed 14 years ago by robertwb

Attachment: 5760-shapes-doctests.patch added

comment:1 Changed 14 years ago by mabshoff

Summary: bring doctest coverage of plot3d/shapes.pyx to 100%[with patch, needs review] bring doctest coverage of plot3d/shapes.pyx to 100%

comment:2 Changed 14 years ago by was

Summary: [with patch, needs review] bring doctest coverage of plot3d/shapes.pyx to 100%[with patch, positive review] bring doctest coverage of plot3d/shapes.pyx to 100%

Wow, not only does this greatly improve the coverage, it appears that several subtle bugs were fixed in 3d plotting along the way!

This example looks awesome, by the way. It's a spotted icosahedron:

show(sphere(opacity=.8,size=1.31) + icosahedron(size=2,opacity=.5,color='red'), frame=False)

comment:3 Changed 14 years ago by mabshoff

Resolution: fixed
Status: newclosed

Merged in Sage 3.4.1.rc3.

Cheers,

Michael

Note: See TracTickets for help on using tickets.