Opened 11 years ago

Closed 11 years ago

#5747 closed enhancement (fixed)

[with patch, positive review] improve doctest coverage for schemes/generic/ambient_space.py

Reported by: AlexGhitza Owned by: AlexGhitza
Priority: major Milestone: sage-3.4.1
Component: algebraic geometry Keywords: doctest scheme ambient space
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description


Attachments (1)

trac_5747.patch (9.3 KB) - added by AlexGhitza 11 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by AlexGhitza

  • Status changed from new to assigned

Changed 11 years ago by AlexGhitza

comment:2 Changed 11 years ago by AlexGhitza

  • Summary changed from improve doctest coverage for schemes/generic/ambient_space.py to [with patch, needs review] improve doctest coverage for schemes/generic/ambient_space.py

The patch brings the doctest coverage from 11% to 100% (17 of 17).

There is some interaction with #5631, since I had to add the missing method _check_verifies_equations() to affine_space.py. I will rebase this patch in case #5631 gets merged in the mean time.

comment:3 Changed 11 years ago by was

  • Summary changed from [with patch, needs review] improve doctest coverage for schemes/generic/ambient_space.py to [with patch, positive review] improve doctest coverage for schemes/generic/ambient_space.py

comment:4 Changed 11 years ago by mabshoff

  • Milestone changed from sage-3.4.2 to sage-3.4.1
  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 3.4.1.rc3.

Cheers,

Michael

Note: See TracTickets for help on using tickets.