Opened 8 years ago

Closed 8 years ago

#5729 closed enhancement (fixed)

[with patch, positive review] Cleanup of crystal code: cartan_type now a method rather than attribute

Reported by: aschilling Owned by: aschillin
Priority: major Milestone: sage-3.4.1
Component: combinatorics Keywords:
Cc: sage-combinat Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by nthiery)

Crystals: cartan_type is a method

  • Changed the API to have cartan type as a method rather than attribute
  • Systematically use .parent() instead of ._parent
  • Minor doc improvements

Attachments (3)

crystal-cleanup-track.patch (18.1 KB) - added by aschilling 8 years ago.
crystal-5729-track.patch (27.4 KB) - added by aschilling 8 years ago.
changed according to Nicolas' suggestions
crystal-5729-track.2.patch (30.7 KB) - added by nthiery 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by aschilling

Changed 8 years ago by aschilling

changed according to Nicolas' suggestions

comment:1 Changed 8 years ago by aschilling

  • Summary changed from Cleanup of crystal code: cartan_type now a method rather than attribute to [with patch, needs review] Cleanup of crystal code: cartan_type now a method rather than attribute

Changed 8 years ago by nthiery

comment:2 Changed 8 years ago by nthiery

  • Cc sage-combinat added
  • Summary changed from [with patch, needs review] Cleanup of crystal code: cartan_type now a method rather than attribute to [with patch, positive review] Cleanup of crystal code: cartan_type now a method rather than attribute

Final version of the patch uploaded:

  • fixes 2/3 remaining calls to parent()
  • Micro doc improvements

comment:3 Changed 8 years ago by nthiery

  • Description modified (diff)

comment:4 Changed 8 years ago by aschilling

  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 8 years ago by mabshoff

  • Resolution fixed deleted
  • Status changed from closed to reopened

Huh? This ticket has not been merged.

Cheers,

Michael

comment:6 Changed 8 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from reopened to closed

Merged crystal-5729-track.2.patch in Sage 3.4.1.rc2.

Cheers,

Michael

Note: See TracTickets for help on using tickets.