Opened 8 years ago
Closed 8 years ago
#5729 closed enhancement (fixed)
[with patch, positive review] Cleanup of crystal code: cartan_type now a method rather than attribute
| Reported by: | aschilling | Owned by: | aschillin |
|---|---|---|---|
| Priority: | major | Milestone: | sage-3.4.1 |
| Component: | combinatorics | Keywords: | |
| Cc: | sage-combinat | Merged in: | |
| Authors: | Reviewers: | ||
| Report Upstream: | Work issues: | ||
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Description (last modified by )
Crystals: cartan_type is a method
- Changed the API to have cartan type as a method rather than attribute
- Systematically use .parent() instead of ._parent
- Minor doc improvements
Attachments (3)
Change History (9)
Changed 8 years ago by
Changed 8 years ago by
comment:1 Changed 8 years ago by
- Summary changed from Cleanup of crystal code: cartan_type now a method rather than attribute to [with patch, needs review] Cleanup of crystal code: cartan_type now a method rather than attribute
Changed 8 years ago by
comment:2 Changed 8 years ago by
- Cc sage-combinat added
- Summary changed from [with patch, needs review] Cleanup of crystal code: cartan_type now a method rather than attribute to [with patch, positive review] Cleanup of crystal code: cartan_type now a method rather than attribute
Final version of the patch uploaded:
- fixes 2/3 remaining calls to parent()
- Micro doc improvements
comment:3 Changed 8 years ago by
- Description modified (diff)
comment:4 Changed 8 years ago by
- Resolution set to fixed
- Status changed from new to closed
comment:5 Changed 8 years ago by
- Resolution fixed deleted
- Status changed from closed to reopened
Huh? This ticket has not been merged.
Cheers,
Michael
comment:6 Changed 8 years ago by
- Resolution set to fixed
- Status changed from reopened to closed
Merged crystal-5729-track.2.patch in Sage 3.4.1.rc2.
Cheers,
Michael
Note: See
TracTickets for help on using
tickets.
changed according to Nicolas' suggestions