Opened 10 years ago
Closed 10 years ago
#5713 closed defect (fixed)
[with patch, positive review] multigraph plotting bug
Reported by: | was | Owned by: | ekirkman |
---|---|---|---|
Priority: | major | Milestone: | sage-3.4.1 |
Component: | graph theory | Keywords: | |
Cc: | rlm | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
I just tried to plot a multigraph with setting positions of vertices, G=Graph({'a':['a','b','b','b','e'],'b':['c','d','e'],'c': ['c','d','d','d'],'d':['e']}) G.show(pos={'a':[0,1],'b':[1,1],'c':[2,0],'d':[1,0],'e':[0,0]}) and got an error File "/home/alec/sage/local/lib/python2.5/site-packages/sage/graphs/ graph_plot.py", line 459, in set_edges odd_y = M[1] + d NameError: global name 'd' is not defined Without pos both show and plot work OK. Alec Mihailovs
Attachments (1)
Change History (5)
comment:1 Changed 10 years ago by
- Cc rlm added
- Milestone changed from sage-3.4.1 to sage-3.4.2
Changed 10 years ago by
comment:2 Changed 10 years ago by
- Milestone changed from sage-3.4.2 to sage-3.4.1
- Summary changed from multigraph plotting bug to [with patch, needs review] multigraph plotting bug
comment:3 Changed 10 years ago by
- Summary changed from [with patch, needs review] multigraph plotting bug to [with patch, positive review] multigraph plotting bug
Ok, given the scope of this patch I am capable of understanding what is going on and I am giving this patch a positive review. Even all doctests pass :)
Cheers,
Michael
comment:4 Changed 10 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged in Sage 3.4.1.rc2.
Cheers,
Michael
Note: See
TracTickets for help on using
tickets.
Is this a high priority issue? I am not convinced and since there is no patch and no sign of anyone working on fixing this I am bumping this to 3.4.2.
Cheers,
Michael