Opened 12 years ago
Closed 11 years ago
#5680 closed enhancement (fixed)
Use new bits from FLINT 1.2.4 (followup to #5240)
Reported by: | mabshoff | Owned by: | malb |
---|---|---|---|
Priority: | major | Milestone: | sage-4.2.1 |
Component: | basic arithmetic | Keywords: | |
Cc: | burcin, wbhart | Merged in: | sage-4.2.1.alpha0 |
Authors: | Burcin Erocal | Reviewers: | Mike Hansen |
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Now that FLINT 1.2.4 is in Sage we should hook up various new methods:
- factor
- square free factoring
- derivative
- powermod
Cheers,
Michael
Attachments (2)
Change History (8)
comment:1 Changed 12 years ago by
- Cc burcin added
comment:2 Changed 11 years ago by
- Cc wbhart added
- Component changed from misc to basic arithmetic
- Status changed from new to needs_review
I attached a patch that exposes some more functionality from FLINT and adds a function for rational reconstruction to zmod_poly wrappers. Changes include:
- factor
- is_irreducible
- scalar multiplication
- is_irreducible
- monic
- evaluate
- short products
- rational function reconstruction (not a FLINT function)
Changed 11 years ago by
comment:3 Changed 11 years ago by
- Status changed from needs_review to needs_work
With Sage 4.2.alpha1, I get the following failures:
sage -t -long devel/sage-main/sage/schemes/elliptic_curves/padics.py # 18 doctests failed sage -t -long devel/sage-main/sage/schemes/elliptic_curves/sha_tate.py # 15 doctests failed sage -t -long devel/sage-main/sage/schemes/elliptic_curves/monsky_washnitzer.py # 5 doctests failed sage -t -long devel/sage-main/sage/schemes/hyperelliptic_curves/hyperelliptic_padic_field.py # 1 doctests failed sage -t -long devel/sage-main/sage/schemes/elliptic_curves/ell_padic_field.py # 2 doctests failed
Also, in squarefree_decomposition, there is an "EXAMPLES:" that needs to be "EXAMPLES::".
Changed 11 years ago by
comment:4 Changed 11 years ago by
- Status changed from needs_work to needs_review
Oops, I hadn't run doctests on schemes
, and it was a genuine bug with scalar multiplication.
New patch attachment:trac_5680-flint_zmod_poly_enhancements.take2.patch should fix all problems.
comment:5 Changed 11 years ago by
- Reviewers set to Mike Hansen
- Status changed from needs_review to positive_review
Looks good to me.
comment:6 Changed 11 years ago by
- Merged in set to sage-4.2.1.alpha0
- Resolution set to fixed
- Status changed from positive_review to closed
Bill suggested that I also CC Burcin on this ticket so he knows that it exists :)
Cheers,
Michael