Opened 12 years ago

Closed 12 years ago

#5654 closed defect (fixed)

[with patch, positive review] Boundary/interior points of vertices were computed wrong.

Reported by: novoselt Owned by: mhampton
Priority: major Milestone: sage-3.4.1
Component: geometry Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This is wrong: 

sage: ReflexivePolytope(2,0).faces(dim=0)[0].nboundary_points()
1

because vertices do not have boundary points.

The patch fixes the function that caused this error.

Attachments (1)

11804.patch​ (2.8 KB) - added by novoselt 12 years ago.

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by novoselt

comment:1 Changed 12 years ago by mhampton

  • Summary changed from [with patch, needs review] Boundary/interior points of vertices were computed wrong. to [with patch, positive review] Boundary/interior points of vertices were computed wrong.

This passes doctests, and is a simple change that makes sense to me.

comment:2 Changed 12 years ago by mabshoff

  • Milestone changed from sage-3.4.2 to sage-3.4.1
  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.4.1.rc3.

Cheers,

Michael

Note: See TracTickets for help on using tickets.