Opened 14 years ago

Closed 14 years ago

#5632 closed defect (fixed)

[with patch, positive review] doc fixes for quaternion algebra element

Reported by: jhpalmieri Owned by: jhpalmieri
Priority: minor Milestone: sage-3.4.1
Component: algebra Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Along the lines of #5541, here are some doc fixes for quaternion_algebra_element.pyx.

Attachments (2)

quaternion.patch (6.8 KB) - added by jhpalmieri 14 years ago.
rebased post #5520, positive review for this patch
quatalg-reference.patch (679 bytes) - added by jhpalmieri 14 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 14 years ago by jhpalmieri

Owner: changed from tbd to jhpalmieri
Status: newassigned

comment:2 Changed 14 years ago by mvngu

jhpalmieri: Can you please provide a link to the spkg you mentioned above? I seem to not find a link or the spkg anywhere on this ticket. Sorry if I've missed anything.

comment:3 Changed 14 years ago by jhpalmieri

Summary: [with spkg; needs review] doc fixes for quaternion algebra element[with patch; needs review] doc fixes for quaternion algebra element

Sorry, should have said "with patch", not "with spkg".

comment:4 Changed 14 years ago by mvngu

Summary: [with patch; needs review] doc fixes for quaternion algebra element[with patch, positive review] doc fixes for quaternion algebra element

Looks good, applies OK against Sage 3.4.1.alpha0, all doctests passed. Positive review.

comment:5 Changed 14 years ago by mabshoff

Summary: [with patch, positive review] doc fixes for quaternion algebra element[with patch, needs rebase] doc fixes for quaternion algebra element

Due to #5520 this patch needs to be rebased:

sage-3.4.1.rc0/devel/sage$ patch -p1 --dry-run < trac_5632_quaternion.patch 
patching file sage/algebras/quatalg/quaternion_algebra_element.pyx
Hunk #1 succeeded at 171 (offset 4 lines).
Hunk #2 succeeded at 354 (offset 140 lines).
Hunk #3 succeeded at 398 (offset 140 lines).
Hunk #4 succeeded at 410 (offset 140 lines).
Hunk #5 succeeded at 422 (offset 140 lines).
Hunk #6 succeeded at 437 (offset 140 lines).
Hunk #7 succeeded at 496 (offset 140 lines).
Hunk #8 succeeded at 537 (offset 167 lines).
Hunk #9 succeeded at 685 (offset 167 lines).
Hunk #10 succeeded at 712 (offset 167 lines).
Hunk #11 succeeded at 797 (offset 224 lines).
Hunk #12 succeeded at 1149 (offset 261 lines).
Hunk #13 succeeded at 1219 (offset 260 lines).
Hunk #14 succeeded at 1244 (offset 260 lines).
Hunk #15 succeeded at 1494 (offset 441 lines).
Hunk #16 succeeded at 1854 (offset 441 lines).
Hunk #17 FAILED at 1912.
1 out of 17 hunks FAILED -- saving rejects to file sage/algebras/quatalg/quaternion_algebra_element.pyx.rej

Cheers,

Michael

comment:6 Changed 14 years ago by jhpalmieri

Summary: [with patch, needs rebase] doc fixes for quaternion algebra element[with patch, positive review] doc fixes for quaternion algebra element

Here's a rebased version. Since the previous one had a positive review, I assume this one does, too.

However, I think we also need something like the attached 'quatalg-reference.patch' to process the moved files for inclusion into the reference manual, but when I apply it and try to build the docs, I get error messages like

Traceback (most recent call last):
  File "/Applications/sage/devel/sage/doc/common/builder.py", line 668, in <module>
    getattr(get_builder(name), type)()
  File "/Applications/sage/devel/sage/doc/common/builder.py", line 348, in _wrapper
    for module_name in self.get_modified_modules():
  File "/Applications/sage/devel/sage/doc/common/builder.py", line 415, in get_modified_modules
    added, changed, removed = env.get_outdated_files(False)
  File "/Applications/sage_builds/sage-3.4.1.alpha0/local/lib/python2.5/site-packages/Sphinx-0.5.1-py2.5.egg/sphinx/environment.py", line 400, in get_outdated_files
    newmtime = path.getmtime(self.doc2path(docname))
  File "/Applications/sage_builds/sage-3.4.1.alpha0/local/lib/python2.5/posixpath.py", line 143, in getmtime
    return os.stat(filename).st_mtime
OSError: [Errno 2] No such file or directory: '/Applications/sage_builds/sage-3.4.1.alpha0/devel/sage-main/doc/en/reference/sage/algebras/quaternion_algebra.rst'

(This fix should have been part of #5520, I think.)

Changed 14 years ago by jhpalmieri

Attachment: quaternion.patch added

rebased post #5520, positive review for this patch

Changed 14 years ago by jhpalmieri

Attachment: quatalg-reference.patch added

comment:7 Changed 14 years ago by mabshoff

For the record: positive review quatalg-reference.patch.

Cheers,

Michael

comment:8 Changed 14 years ago by mabshoff

Resolution: fixed
Status: assignedclosed

Merged in Sage 3.4.1.rc0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.