Opened 14 years ago
Closed 14 years ago
#5630 closed enhancement (fixed)
[with patch, positive review] improve doctest coverage for schemes/generic/spec.py
Reported by: | AlexGhitza | Owned by: | AlexGhitza |
---|---|---|---|
Priority: | minor | Milestone: | sage-3.4.1 |
Component: | algebraic geometry | Keywords: | spec doctest latex |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
The attached patch adds a _latex_()
method for Spec's of rings and improves the doctest coverage of spec.py
from 42% (3 of 7) to 75% (6 of 8).
The two remaining methods are currently involved in other tickets that will also take care of adding doctests: see #5629 for dimension()
and #5479 for __call__()
Attachments (1)
Change History (8)
comment:1 Changed 14 years ago by
Summary: | improve doctest coverage for schemes/generic/spec.py → [with patch, needs review] improve doctest coverage for schemes/generic/spec.py |
---|
comment:2 Changed 14 years ago by
Owner: | changed from was to AlexGhitza |
---|
comment:3 Changed 14 years ago by
Status: | new → assigned |
---|
comment:4 Changed 14 years ago by
Summary: | [with patch, needs review] improve doctest coverage for schemes/generic/spec.py → [with patch, needs work] improve doctest coverage for schemes/generic/spec.py |
---|
Changed 14 years ago by
Attachment: | trac_5630.patch added |
---|
comment:5 Changed 14 years ago by
Summary: | [with patch, needs work] improve doctest coverage for schemes/generic/spec.py → [with patch, needs review] improve doctest coverage for schemes/generic/spec.py |
---|
Ah, I had misinterpreted the existing docstring for _cmp_
. I removed the offending doctest (the one with Spec(QQ) == 5
is already there) and clarified the docstring a little bit.
New patch is up replacing the old one.
comment:6 Changed 14 years ago by
Summary: | [with patch, needs review] improve doctest coverage for schemes/generic/spec.py → [with patch, positive review] improve doctest coverage for schemes/generic/spec.py |
---|
comment:7 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Merged in Sage 3.4.1.rc0.
Cheers,
Michael
Note: See
TracTickets for help on using
tickets.
This doctest fails for me on 32-bit OS X:
Since the result is meaningless, you could flag it
or instead have a test
If you fix this one issue, then this will get "positive review" from me.