Opened 14 years ago
Last modified 10 years ago
#5457 closed enhancement
Refactor symmetric functions and k-bounded subspace — at Version 42
Reported by: | Nicolas M. Thiéry | Owned by: | Mike Hansen |
---|---|---|---|
Priority: | major | Milestone: | sage-5.4 |
Component: | combinatorics | Keywords: | symmetric functions, days38, sd40 |
Cc: | Sage Combinat CC user, Franco Saliola, Daniel Bump, Chris Berg, Mike Zabrocki, Simon King | Merged in: | |
Authors: | Mike Zabrocki, Anne Schilling, Jason Bandlow | Reviewers: | Dan Bump, Nicolas M. Thiery |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #11563, #13109, #12969 | Stopgaps: |
Description (last modified by )
This patch restructures the implementation of symmetric functions in sage
The new implementation makes use of multiple realizations and the category framework. The new access to symmetric functions is via
sage: Sym = SymmetricFunctions(QQ)
Further new features that are implemented:
- The ring of symmetric functions is now endowed with a Hopf algebra structure. The coproduct and antipode are implemented (which were missing before).
- A tutorial on how to use symmetric functions in sage is included at the beginning of sf.py which is also accessible via
sage: SymmetricFunctions??
- Symmetric functions should now work a lot better with respect to specializing parameters like
q
andt
for Hall-Littlewood, Jack and Macdonald symmetric functions. Certain functionalities before this change were broken or not possible.
- Documentation was added to LLT polynomials (which had very sparse documentation previously).
- The
k
-bounded subspace of the ring of symmetric function was implemented. Thek
-Schur functions now live in thek
-bounded subspace rather than in the ring of symmetric functions as before.
This patch gained tremendously by the tutorial on symmetric functions written by Jason Bandlow, a draft on the k
-bounded subspace by Jason Bandlow, and code multiple realizations written by Franco Saliola.
See also http://groups.google.com/group/sage-devel/msg/a49f3288fca1b75c
Apply
Change History (42)
comment:1 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 14 years ago by
Cc: | Sage Combinat CC user added |
---|
comment:3 Changed 10 years ago by
Dependencies: | → 13109 |
---|---|
Report Upstream: | → N/A |
comment:4 Changed 10 years ago by
Dependencies: | 13109 |
---|
comment:5 Changed 10 years ago by
Authors: | → Mike Zabrocki, Anne Schilling |
---|---|
Description: | modified (diff) |
Keywords: | symmetric functions sd38 sd40 added |
Reviewers: | → Dan Bump, Franco Saliola |
Summary: | Refactor symmetric functions → Refactor symmetric functions and k-bounded subspace |
comment:6 Changed 10 years ago by
Cc: | Franco Saliola Daniel Bump Chris Berg added |
---|
comment:7 Changed 10 years ago by
Cc: | Mike Zabrocki added |
---|
comment:8 Changed 10 years ago by
Status: | new → needs_review |
---|
comment:9 Changed 10 years ago by
Status: | needs_review → needs_work |
---|
comment:10 Changed 10 years ago by
comment:11 Changed 10 years ago by
Authors: | Mike Zabrocki, Anne Schilling → Mike Zabrocki, Anne Schilling, Jason Bandlow |
---|
comment:12 Changed 10 years ago by
Dependencies: | → #11563 |
---|
comment:13 Changed 10 years ago by
Dependencies: | #11563 → #11563, #13109 |
---|
comment:14 follow-up: 15 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:15 follow-up: 16 Changed 10 years ago by
Hi Mike,
I completed the doctests for sfa.py and also rebased everything on top of 13109. Please put your changes to
- hall_littlewood.py
- jack.py
- llt.py
- macdonald.py
on top of the current patch trac_5457-symmetric_functions-mz.patch. Unfortunately we need to abandon the sage-combinat queue for the moment since it would be very cumbersome to keep it backward compatible with 13109. I will send you a separate e-mail on how to proceed.
Cheers,
Anne
comment:16 Changed 10 years ago by
Ok, patch is ready for review! It should apply and run cleanly on sage.5.2.rc0!
Anne
comment:17 Changed 10 years ago by
Status: | needs_work → needs_review |
---|
comment:19 Changed 10 years ago by
Cc: | Simon King added |
---|
comment:20 follow-up: 21 Changed 10 years ago by
Hi Dan!
Thank you very much for your comments on the failing doctests in
- devel/sage/sage/algebras/nil_coxeter_algebra.py
- devel/sage/sage/categories/realizations.py
They are fixed in the updated version of the patch. I do not get failures for
- devel/sage/sage/sandpiles/sandpile.py
on my machine.
lolita-4:sandpiles anne$ sage -t sandpile.py sage -t "devel/sage-sf/sage/sandpiles/sandpile.py"
[19.0 s]
All tests passed! Total time for all tests: 19.0 seconds
Anne
comment:21 Changed 10 years ago by
Replying to aschilling:
Hi Dan!
Thank you very much for your comments on the failing doctests in
- devel/sage/sage/algebras/nil_coxeter_algebra.py
- devel/sage/sage/categories/realizations.py
They are fixed in the updated version of the patch. I do not get failures for
- devel/sage/sage/sandpiles/sandpile.py
on my machine.
I also get a doctest failure in sandpile.py with unpatched sage-5.2.rc0 so this failure is not caused by the patch.
comment:23 follow-up: 24 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:24 Changed 10 years ago by
The attached review patch trac_5457-review-as.patch incorporates most of the comments that Dan Bump raised in e-mail conversations.
Anne
comment:25 follow-up: 26 Changed 10 years ago by
Description: | modified (diff) |
---|---|
Status: | needs_review → positive_review |
This patch is a huge step forward for symmetric functions.
In addition to normal testing I spent quite a bit of time and privately sent comments (mainly on documentation) that have been taken into account in trac_5457-review-as.patch. I'm changing the status to positive review.
comment:26 Changed 10 years ago by
Replying to bump:
This patch is a huge step forward for symmetric functions.
In addition to normal testing I spent quite a bit of time and privately sent comments (mainly on documentation) that have been taken into account in trac_5457-review-as.patch. I'm changing the status to positive review.
Dear Dan, Thank you so much for your thorough and quick review of this huge patch! Mike and I just finished the review patch. Tests pass on both of our machines.
Anne
comment:27 follow-up: 28 Changed 10 years ago by
I have reviewed the latest version of the patch and it still has positive review.
comment:28 Changed 10 years ago by
Since http://trac.sagemath.org/sage_trac/ticket/12969 just got merged into sage-5.3.beta0, please also apply the attachment trac12969_rel_5457.patch on the ticket 12969 to this patch. Otherwise there will be doctest failures.
Thanks,
Anne
comment:29 Changed 10 years ago by
Dependencies: | #11563, #13109 → #11563, #13109, #12969 |
---|
comment:30 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:31 Changed 10 years ago by
This needs to be rebased to sage-5.3.beta0 (not yet released):
patching file sage/categories/realizations.py Hunk #1 FAILED at 74 1 out of 1 hunks FAILED -- saving rejects to file sage/categories/realizations.py.rej patching file sage/combinat/sf/classical.py Hunk #3 FAILED at 88 1 out of 9 hunks FAILED -- saving rejects to file sage/combinat/sf/classical.py.rej patching file sage/combinat/sf/sfa.py Hunk #61 FAILED at 2589 1 out of 63 hunks FAILED -- saving rejects to file sage/combinat/sf/sfa.py.rej abort: patch failed to apply
comment:32 Changed 10 years ago by
Status: | positive_review → needs_work |
---|
comment:33 follow-up: 34 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:34 Changed 10 years ago by
I rebased and folded the three patches with respect to sage-5.3.beta0 from yesterday. It should apply cleanly now.
Mike and I are still going to fix one math bug that someone at FPSAC found.
Anne
comment:35 Changed 10 years ago by
Hi Dan,
Our new rebased patch is attached. You only need to apply trac_5457-symmetric_functions-mz.patch. Note that we did not fix apply_linear_morphism in /category/module_with_basis.py yet since Nicolas seems to have a review patch for this, but unfortunately his tests did not pass. Either he needs to fix his review patch or we will add your suggestion from the e-mail.
Anne
comment:36 Changed 10 years ago by
Status: | needs_work → needs_review |
---|
comment:37 follow-up: 38 Changed 10 years ago by
Note: I inserted in the queue the latest patch rebased for 5.3 beta0 from here. My review patch is also there, ready to be folded if you are happy with it.
comment:38 Changed 10 years ago by
Dear Dan and Nicolas,
Thank you so much for your reviews and work on this patch! I incorporated the changes that Dan suggested by e-mail and folded Nicolas' review patch. In addition, Mike had some minor improvements in the documentation of llt.py which are incorporated.
The new patch should apply cleanly on sage-5.3.beta0.
Anne
comment:39 Changed 10 years ago by
Reviewers: | Dan Bump, Franco Saliola → Dan Bump, Nicolas M. Thiery |
---|
comment:40 Changed 10 years ago by
All tests pass with sage-5.3.beta0. The changes discussed over the last few days have all been incorporated. I think this is ready to go.
comment:41 Changed 10 years ago by
Status: | needs_review → positive_review |
---|
comment:42 Changed 10 years ago by
Description: | modified (diff) |
---|
Hi Mike,
I finished the doctests for the following files:
In particular, at the beginning of sf.py I incorporated the tutorial that Jason and Nicolas wrote (which was further down the queue) and updated it. I marked them there as coauthors in that file.
This leaves the doctests for
which I suppose you will do in the next couple of days? In particular, in the sfa.py the deprecation warnings need to be activated which I have not yet done.
Best,
Anne