Opened 10 years ago

Last modified 5 years ago

#5419 new defect

moving fraction field to new coercion broke old pickles

Reported by: craigcitro Owned by: craigcitro
Priority: major Milestone: sage-6.4
Component: misc Keywords:
Cc: burcin Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

At some point, fraction fields were moved over to the new coercion model, which is good -- except that it broke all the old pickles. This thread on sage-support is about someone having a problem with them: http://groups.google.com/group/sage-support/browse_thread/thread/b5519db45a141819

The problem is that the old pickles don't have _element_class or _element_constructor fields, and there was no factory function in place -- so unpickling tries to directly create the object, which totally fails. Putting the old __call__ method back in place is an ugly hack to get these to load, but it's not a good permanent solution.

Change History (5)

comment:1 Changed 10 years ago by mabshoff

  • Component changed from algebra to misc
  • Milestone set to sage-3.4.1

Hmm,

how did this escape the pickle jar doctest?

Cheers,

Michael

comment:2 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:3 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:4 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:5 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4
Note: See TracTickets for help on using tickets.