Opened 10 years ago

Closed 10 years ago

#5380 closed enhancement (fixed)

[with patch; positive review] devmap: allow to search for contributions by trac username

Reported by: mvngu Owned by: schilly
Priority: minor Milestone: sage-3.4.1
Component: website/wiki Keywords: devmap
Cc: schilly Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The development map (devmap) at

http://www.sagemath.org/development-map.html

currently supports search of a developer's contributions by her/his real name. For most developers, their real names diff from their trac usernames. The devmap should support search of contributions by trac usernames as well.

Attachments (4)

trac_5380_search-by-username.patch (40.4 KB) - added by mvngu 10 years ago.
diff against previous version of contributors.xml
trac_5380_remove-yi-username.patch (1.8 KB) - added by mvngu 10 years ago.
Remove Yi Qiang's trac username
trac_5380_remove-usernames.patch (9.5 KB) - added by mvngu 10 years ago.
Remove trac usernames of some people
contributors.xml (24.7 KB) - added by mvngu 10 years ago.
Updated contributors list

Download all attachments as: .zip

Change History (15)

Changed 10 years ago by mvngu

diff against previous version of contributors.xml

comment:1 Changed 10 years ago by mvngu

The attached XML file contributors.xml is an updated version of the file

http://www.sagemath.org/res/contributors.xml

The new version adds trac usernames of most people listed on the Sage development map. However, there are still a number of developers for whom that I've not been able to determine their trac usernames. These people are:

  1. Antti Ajanki
  2. Bill Allombert
  3. Benjamin Antieau
  4. Jennifer Balakrishnan
  5. Gregory Bard
  6. Karim Belabas
  7. Jonathan Bober
  8. Michael Brickenstein
  9. Nils Bruin
  10. Wilson Cheung
  11. Alex Clemesha
  12. Doug Cutrell
  13. Alyson Deines
  14. Tom Denton
  15. Jan Groenewald
  16. Rob Gross
  17. Bill Hart
  18. Leif Hille
  19. Neal Holtz
  20. Sean Howe
  21. Naqi Jaffery
  22. Peter Jipsen
  23. Michael Kallweit
  24. Jason Martin
  25. Kate Minola
  26. Rich Morin
  27. Gregg Musiker
  28. David Perkinson
  29. Pearu Peterson
  30. Bill Purvis
  31. Dorian Raymer
  32. R. Rishikesh
  33. Gordon Royle
  34. Kyle Schalm
  35. Jack Schmidt
  36. Denis Simone
  37. Steven Sivek
  38. Griffen Thoma
  39. Michel Vandenbergh
  40. Steve Vonn
  41. Mark Watkins
  42. Joe Wetherell
  43. Dal S. Yu
  44. Gary Zablackis
  45. Mike Zabrocki
  46. Bin Zhang

However, Alexander Dreyer's trac username looks suspicious/ambiguous to me. I think his trac username is "PolyBoRi?". I've also attached the patch file trac_5380_search-by-username.patch which should be useful for reviewers who want to view differences between the updated version of contributors.xml and the previous version at http://www.sagemath.org/res/contributors.xml.

comment:2 Changed 10 years ago by mvngu

  • Summary changed from devmap: allow to search for contributions by trac username to [with patch; needs review] devmap: allow to search for contributions by trac username

comment:3 Changed 10 years ago by mabshoff

Hi Minh,

  • not all people listed with credit have trac accounts, but I can go over the list
  • PolyBoRi? is a single account for Alexander Dreyer and Michael Brickenstein - we might want to fix that.

Cheers,

Michael

comment:4 follow-up: Changed 10 years ago by schilly

ok, thanks, that was fast!

file uploaded and everything working. just too bad that trac doesn't support searching by username, just this full text stuff, but indeed nice to be able to see where he/she had the fingers in :)

comment:5 in reply to: ↑ 4 ; follow-up: Changed 10 years ago by mvngu

Replying to schilly:

file uploaded and everything working. just too bad that trac doesn't support searching by username, just this full text stuff, but indeed nice to be able to see where he/she had the fingers in :)

OK, with contributors.xml uploaded, I see that visitors to the devmap are able to search for a developer's contribution. If the said XML file contains a developer's trac username, then the visitor would be presented with a list of (possible) contributions made by the developer in question. However, if the XML file doesn't contain the developer's trac username, then the search query would be made using the developer's full name as provided on the devmap.

However, I still see a number of weird things in the trac search functionalities. Disclaimer: I'm not an expert on how the trac server searches for a developer's contributions.

  1. In cases where a developer's trac username has not appeared on any trac tickets, the search is still performed using the developer's username. I think this would likely result in a misleading list of search results, and the said developer's contribution on trac tickets would be missed by the search. A case in point is Maite Aranes, who has the username "mtaranes". After clicking on the link "search contributions", the search result is just Maite's name highlighted on the page

    http://trac.sagemath.org/sage_trac/wiki/WikiStart

    From the release note of Sage 3.3 and release tour, I'm 99.9% certain that Maite has contributed code in that release, in particular the ticket #4831.
  2. If a developer's trac username is two characters in length, then the search query returns a "Search Error" message, with the explanation
    Search query too short. Query must be at least 3 characters long.
    
    For example, Yi Qiang's username is "yi" and a search of his contribution returns a search error. This is weird, because Yi has made substantial contributions to the dsage package, and I think he's the original developer of dsage. I'm not sure how to fix this. However, an ad hoc fix might be to have the following policy for trac usernames: i.e. a trac username must be at least 3 characters in length. Perhaps someone can suggest a better workaround.

Apart from the above comments, someone else should verify/review this ticket and the updated devmap.

comment:6 Changed 10 years ago by mabshoff

  • Milestone changed from sage-3.4 to sage-3.4.1

Better luck in 3.4.1.

Cheers,

Michael

comment:7 in reply to: ↑ 5 Changed 10 years ago by schilly

Replying to mvngu:

However, if the XML file doesn't contain the developer's trac username, then the search query would be made using the developer's full name as provided on the devmap.

i wanted to find a way to search for contributions where no trac account is known. That's why i take the real name. Plan B would have been to only include the link for those, where a trac account name is given and not for all the others. Testing some names seemed to be good enough to include the real name for those where no trac account is given...

Mixing trac account name and real name turned out to be a bad idea. In that case, sometimes nothing at all was found.

"yi" and a search of his contribution returns a search error.

yeahr well, trac search isn't good. probably searching with google (restricted site search on trac.sagemath.org) would be better - at least for two letter words like this one ;)

harald

Changed 10 years ago by mvngu

Remove Yi Qiang's trac username

Changed 10 years ago by mvngu

Remove trac usernames of some people

Changed 10 years ago by mvngu

Updated contributors list

comment:8 follow-up: Changed 10 years ago by mvngu

The updated contributors list contributors.xml is similar to the previous version, except that Yi Qiang's trac username has been removed so that we can search for his contribution using this full name. This search option would result in more matches than getting an error message when searching with two letters. I encountered another problem while searching contributions of the following people:

  1. Timothy Clemans
  2. Alexander Dreyer
  3. Alex Ghitza
  4. Simon King
  5. Nils-Peter Skoruppa

using the "Search contributions" links at

http://www.sagemath.org/development-map.html

Searching contributions of each of the above people result in a wiki page that says something like this:

http://trac.sagemath.org/sage_trac/wiki/TimothyClemans

That's because the trac search function mistakens the trac usernames of these people as empty wiki pages. So for now, the updated contributors list no longer has the trac usernames of the above people. Once the updated list contributors.xml is uploaded, a reviewer should check on the (new) devmap that clicking on the "Search contributions" links next to the above people, including Yi Qiang, should return some search results, which should not be error messages, or empty wiki pages. Other than the above comments, I think this messy ticket can be closed, unless someome has suggestions.

comment:9 in reply to: ↑ 8 ; follow-up: Changed 10 years ago by schilly

Replying to mvngu:

The updated contributors list contributors.xml...

I've updated the website with that file. Changes looked good to me.

comment:10 in reply to: ↑ 9 Changed 10 years ago by mabshoff

  • Milestone changed from sage-3.4.2 to sage-3.4.1
  • Summary changed from [with patch; needs review] devmap: allow to search for contributions by trac username to [with patch; positive review] devmap: allow to search for contributions by trac username

Replying to schilly:

Replying to mvngu:

The updated contributors list contributors.xml...

I've updated the website with that file. Changes looked good to me.

Changing it to a positive review.

Cheers,

Michael

comment:11 Changed 10 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.4.1.alpha0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.