Opened 11 years ago

Closed 11 years ago

#5356 closed defect (fixed)

[with patch, positive review] 100r returns a Sage integer in the notebook (but commandline works fine)

Reported by: jason Owned by: boothby
Priority: blocker Milestone: sage-3.4
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

type(100r) returns

<type 'sage.rings.integer.Integer'>

in the notebook in 3.3. Similarly, type(1.0r) returns

<type 'sage.rings.real_mpfr.RealLiteral?'>

Both of these examples work fine on the command line (i.e., return python int and float, respectively).

Attachments (1)

5356-notebook-preparser.patch (2.0 KB) - added by robertwb 11 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by jason

  • Milestone set to sage-3.4

Changed 11 years ago by robertwb

comment:2 Changed 11 years ago by robertwb

  • Summary changed from 100r returns a Sage integer in the notebook (but commandline works fine) to [with patch, needs review] 100r returns a Sage integer in the notebook (but commandline works fine)

comment:3 Changed 11 years ago by jason

  • Summary changed from [with patch, needs review] 100r returns a Sage integer in the notebook (but commandline works fine) to [with patch, positive review] 100r returns a Sage integer in the notebook (but commandline works fine)

This patch fixes the problem and passes doctests in preparser.py. Someone more familiar with the preparse might look at it, but it's a positive review for me.

comment:4 Changed 11 years ago by was

+1 from me.

comment:5 Changed 11 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.4.alpha0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.