Opened 13 years ago

Closed 13 years ago

#5349 closed defect (fixed)

[with patch, positive review] Make extensions linking against libSingular depend on $SAGE_LOCAL/include/libsingular.h

Reported by: mabshoff Owned by: mabshoff
Priority: major Milestone: sage-3.4
Component: build Keywords:
Cc: GeorgSWeber Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The summary says it all. It causes the extensions to be automatically being rebuild when the singular.spkg has been rebuild.

Georg: Can you review this?

Cheers,

Michael

Attachments (1)

trac_5349.patch (2.6 KB) - added by mabshoff 13 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 13 years ago by mabshoff

  • Status changed from new to assigned

Changed 13 years ago by mabshoff

comment:2 Changed 13 years ago by cwitty

  • Summary changed from [with patch, needs review] Make extensions linking against libSingular depend on $SAGE_LOCAL/include/libsingular.h to [with patch, positive review] Make extensions linking against libSingular depend on $SAGE_LOCAL/include/libsingular.h

I tested it; it works. Positive review.

comment:3 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 3.4.alpha0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.