#5290 closed defect (fixed)
[with patch, positive review] Sage 3.3.rc1: Sage fails to start due to dangling missed import in plot.py
Reported by: | mabshoff | Owned by: | mabshoff |
---|---|---|---|
Priority: | blocker | Milestone: | sage-3.3 |
Component: | build | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
It wasn't my fault, but patch is coming up.
Cheers,
Michael
Attachments (2)
Change History (8)
comment:1 Changed 12 years ago by
- Status changed from new to assigned
comment:2 Changed 12 years ago by
- Summary changed from Sage 3.3.rc1: Sage fails to start due to dangling missed import in plot.py to [with patch, needs review] Sage 3.3.rc1: Sage fails to start due to dangling missed import in plot.py
comment:3 Changed 12 years ago by
Changed 12 years ago by
comment:4 Changed 12 years ago by
If the patch is changed to deleting the line instead of just commenting it out, positive review. It fixes my rc1 so that it starts up.
Changed 12 years ago by
comment:5 Changed 12 years ago by
- Resolution set to fixed
- Status changed from assigned to closed
Merged both patches in Sage 3.3.rc2.
Cheers,
Michael
comment:6 Changed 12 years ago by
- Summary changed from [with patch, needs review] Sage 3.3.rc1: Sage fails to start due to dangling missed import in plot.py to [with patch, positive review] Sage 3.3.rc1: Sage fails to start due to dangling missed import in plot.py
Ok, changing the review to an offical positive review.
Cheers,
Michael
Note: See
TracTickets for help on using
tickets.
We all agree that the correct fix is to *delete* the offending line, not just comment it out.