Opened 14 years ago

Closed 14 years ago

#518 closed defect (fixed)

fix the indentation in monsky_washnitzer.py to be *FOUR* spaces not two.

Reported by: was Owned by: dmharvey
Priority: minor Milestone: sage-2.8.4
Component: basic arithmetic Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description


Attachments (2)

mw-indentation.patch (72.8 KB) - added by dmharvey 14 years ago.
fix indentation
mw-indentation2.hg (11.2 KB) - added by dmharvey 14 years ago.
let's try that again

Download all attachments as: .zip

Change History (7)

Changed 14 years ago by dmharvey

fix indentation

comment:1 Changed 14 years ago by dmharvey

  • Status changed from new to assigned

comment:2 Changed 14 years ago by dmharvey

  • Milestone changed from sage-2.9 to sage-2.8.4

comment:3 Changed 14 years ago by was

I am unable to apply this patch:

hg_sage.sage: hg_sage.apply('mw-indentation.patch')
cd "/home/was/s/devel/sage" && hg status
cd "/home/was/s/devel/sage" && hg status
cd "/home/was/s/devel/sage" && hg import   "/home/was/Desktop/mw-indentation.patch"
applying /home/was/Desktop/mw-indentation.patch
sage/schemes/elliptic_curves/monsky_washnitzer.py
Hunk #1 FAILED at 60.
Hunk #7 FAILED at 1150.
Hunk #8 FAILED at 1215.
3 out of 9 hunks FAILED -- saving rejects to file sage/schemes/elliptic_curves/monsky_washnitzer.py.rej
abort: patch command failed: exited with status 1
sage:

And it really genuinely is mostly not applied.

comment:4 Changed 14 years ago by was

[11:18] <dmharvey> #518: okay, I guess I'll just go through and do it again at some point. I think the real problem here is to do with trac. I posted the patch a while back, but it didn't get rolled into the repository until now. But meanwhile you and robert had done a bunch of things.

Changed 14 years ago by dmharvey

let's try that again

comment:5 Changed 14 years ago by was

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.