Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5176 closed defect (fixed)

[with patch, positive review] notebook chokes horribly on Umlautes

Reported by: malb Owned by: boothby
Priority: blocker Milestone: sage-3.3
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

I have worksheet with the word "Gröbner" in it which prevents me from using the notebook at all because the listing of worksheets crashes.

        Traceback (most recent call last):
          File ".../twisted/internet/defer.py", line 186, in addCallbacks
            self._runCallbacks()
          File ".../twisted/internet/defer.py", line 328, in _runCallbacks
            self.result = callback(self.result, *args, **kw)
          File ".../twisted/internet/defer.py", line 289, in _continue
            self.unpause()
          File ".../twisted/internet/defer.py", line 285, in unpause
            self._runCallbacks()
        --- <exception caught here> ---
          File ".../twisted/internet/defer.py", line 328, in _runCallbacks
            self.result = callback(self.result, *args, **kw)
          File ".../twisted/web2/server.py", line 296, in <lambda>
            d.addCallback(lambda res, req: res.renderHTTP(req), self)
          File ".../twisted/web2/resource.py", line 85, in renderHTTP
            return method(request)
          File ".../twisted/web2/resource.py", line 202, in http_GET
            return super(Resource, self).http_GET(request)
          File ".../twisted/web2/resource.py", line 128, in http_GET
            return self.render(request)
          File ".../sage/server/notebook/twist.py", line 1408, in render
            return self.render_list(ctx)
          File ".../sage/server/notebook/twist.py", line 1403, in render_list
            s = render_worksheet_list(ctx.args, pub=False, username=self.user)
          File ".../sage/server/notebook/twist.py", line 1390, in render_worksheet_list
            return template('worksheet_listing.html', **locals())
          File ".../sage/server/notebook/template.py", line 70, in template
            return str(tmpl.render(**context))
        exceptions.UnicodeEncodeError: 'ascii' codec can't encode character u'\xf6' in position 4445: ordinal not in range(128)

Before umlauts where displayed wrong but at least they didn't crash the server.

Attachments (2)

trac_5176.patch (729 bytes) - added by malb 12 years ago.
trac_5176.2.patch (1.1 KB) - added by malb 12 years ago.

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by malb

comment:1 Changed 12 years ago by malb

  • Summary changed from notebook chokes horribly on Umlautes to [with patch, needs review] notebook chokes horribly on Umlautes

Changed 12 years ago by malb

comment:2 Changed 12 years ago by jason

  • Summary changed from [with patch, needs review] notebook chokes horribly on Umlautes to [with patch, positive review] notebook chokes horribly on Umlautes

patch looks good, fixes the crashing for me, and is doctested. Positive review.

comment:3 Changed 12 years ago by jason

[13:09] <mabshoff> Someone needs to make sure we can still clone the repo with that patch since last time we had Nicola's name spelled correctly in a patch we had issues like that.

I did not do the above. mabshoff, if you feel it's needed, can you check it before you merge?

comment:4 Changed 12 years ago by mabshoff

I tested cloning on sage.math and it works there. I will only merge trac_5176.2.patch.

Jason: when you review tickets with multiple patches please make clear which patches need to be applied. In this case it was obvious once I looked at both patches.

Cheers,

Michael

comment:5 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged trac_5176.2.patch only in Sage 3.3.alpha6.

Cheers,

Michael

comment:6 Changed 12 years ago by jason

sorry. You're right to merge the .2.patch file.

Note: See TracTickets for help on using tickets.