Opened 13 years ago

Closed 13 years ago

Last modified 6 years ago

#5129 closed defect (fixed)

[with patch, positive review] numerical noise in roots calculus/calculus.py

Reported by: jsp Owned by: mabshoff
Priority: blocker Milestone: sage-3.3
Component: calculus Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

[jaap@peace sage-3.3.alpha0]$ ./sage -t "devel/sage/sage/calculus/calculus.py"
sage -t  "devel/sage/sage/calculus/calculus.py"
**********************************************************************
File "/home/jaap/Download/sage-3.3.alpha0/devel/sage/sage/calculus/calculus.py",
line 3206:
    sage: f.roots(ring=CC)
Expected:
    [(-0.0588115223184495, 1), (1.36050567903502 + 1.51880872209965*I,
1), (-1.33109991787579 + 1.52241655183732*I, 1), (1.36050567903502 -
1.51880872209965*I, 1), (-1.33109991787580 - 1.52241655183732*I, 1)]
Got:
    [(-0.0588115223184495, 1), (1.36050567903502 + 1.51880872209965*I,
1), (-1.33109991787580 + 1.52241655183732*I, 1), (1.36050567903502 -
1.51880872209965*I, 1), (-1.33109991787580 - 1.52241655183732*I, 1)]
**********************************************************************
File "/home/jaap/Download/sage-3.3.alpha0/devel/sage/sage/calculus/calculus.py",
line 3208:
    sage: (2.5*f).roots(ring=RR)
Expected:
    [(-0.0588115223184494, 1)]
Got:
    [(-0.0588115223184495, 1)]
**********************************************************************
File "/home/jaap/Download/sage-3.3.alpha0/devel/sage/sage/calculus/calculus.py",
line 3210:
    sage: f.roots(ring=CC, multiplicities=False)
Expected:
    [-0.0588115223184495, 1.36050567903502 + 1.51880872209965*I,
-1.33109991787579 + 1.52241655183732*I, 1.36050567903502 -
1.51880872209965*I, -1.33109991787580 - 1.52241655183732*I]
Got:
    [-0.0588115223184495, 1.36050567903502 + 1.51880872209965*I,
-1.33109991787580 + 1.52241655183732*I, 1.36050567903502 -
1.51880872209965*I, -1.33109991787580 - 1.52241655183732*I]
**********************************************************************
1 items had failures:
   3 of  29 in __main__.example_81
***Test Failed*** 3 failures.
For whitespace errors, see the file
/home/jaap/Download/sage-3.3.alpha0/tmp/.doctest_calculus.py
 [243.9 s]
exit code: 1024

------------------------------

This is on Fedora 10, 32 bits.

Jaap

Attachments (1)

trac_5129.patch (1.6 KB) - added by mabshoff 13 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by mabshoff

  • Owner changed from burcin to mabshoff
  • Priority changed from major to blocker
  • Status changed from new to assigned

This is a blocker!

Cheers,

Michael

Changed 13 years ago by mabshoff

comment:2 Changed 13 years ago by mabshoff

  • Summary changed from numerical noise in roots calculus/calculus.py to [with patch, needs review] numerical noise in roots calculus/calculus.py

Patch is up.

Cheers,

Michael

comment:3 Changed 13 years ago by jsp

  • Summary changed from [with patch, needs review] numerical noise in roots calculus/calculus.py to [with patch, positive review] numerical noise in roots calculus/calculus.py

On Fedora 9, 32 bits:

[jaap@paix sage-3.3.alpha3]$ ./sage -t "devel/sage/sage/calculus/calculus.py"
sage -t  "devel/sage/sage/calculus/calculus.py"             
	 [171.4 s]
 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 171.4 seconds

Looks good to me!

Jaap

comment:4 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 3.3.alpha5.

Cheers,

Michael

comment:5 Changed 6 years ago by chapoton

  • Description modified (diff)
  • Report Upstream set to N/A
Note: See TracTickets for help on using tickets.