Opened 12 years ago
Closed 12 years ago
#5066 closed defect (fixed)
[with patch, positive review] break out relative number fields into separate file
Reported by: | ncalexan | Owned by: | was |
---|---|---|---|
Priority: | minor | Milestone: | sage-3.3 |
Component: | number theory | Keywords: | relative number fields files |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
This has been some time coming, but let's separate relative number fields from generic/absolute number fields now, while I'm looking at them.
Attachments (1)
Change History (7)
Changed 12 years ago by
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
- Summary changed from [with patch, needs review] break out relative number fields into separate file to [with patch, needs work] break out relative number fields into separate file
Looks good, assuming that the other patch you mentioned (which isn't #1357) gets in at the same time. The only change that needs to be made is in sage.rings.polynomials.polynomial_quotient_ring_element, changing number_field to number_field_rel a couple places.
comment:3 Changed 12 years ago by
- Summary changed from [with patch, needs work] break out relative number fields into separate file to [with patch, needs review] break out relative number fields into separate file
comment:4 Changed 12 years ago by
- Summary changed from [with patch, needs review] break out relative number fields into separate file to [with patch, positive review] break out relative number fields into separate file
comment:5 Changed 12 years ago by
- Milestone changed from sage-3.4 to sage-3.3
comment:6 Changed 12 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged in Sage 3.3.alpha3.
Cheers,
Michael
Note: See
TracTickets for help on using
tickets.
Fails a doctest, to be addressed by patches to #1357 (which will depend on this)