Opened 14 years ago

Closed 14 years ago

#5061 closed defect (fixed)

[with patch, positive review] Steenrod algebras report additive order of 0 is p

Reported by: Kelly Boothby Owned by: Kelly Boothby
Priority: trivial Milestone: sage-3.4
Component: algebra Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This is wrong:

sage: S2 = SteenrodAlgebra(2)
sage: z = S2(0)
sage: z.additive_order()
2

looking at the code, it's easy to see why this happens...

    def additive_order(self):
        """
        The additive order of any element of the mod p Steenrod algebra is p.

        OUTPUT:
            order -- positive prime number

        EXAMPLES:
            sage: z = Sq(4) + Sq(6) + Sq(0)
            sage: z.additive_order()
            2
        """
        return self._prime

Attachments (2)

5061-steenrod-ao.patch (749 bytes) - added by Kelly Boothby 14 years ago.
5061-doc.patch (1012 bytes) - added by John Palmieri 14 years ago.
apply on top of other patch

Download all attachments as: .zip

Change History (9)

comment:1 Changed 14 years ago by Kelly Boothby

Component: algebracommutative algebra
Milestone: sage-3.3
Owner: changed from tbd to Kelly Boothby
Priority: majortrivial
Status: newassigned

comment:2 Changed 14 years ago by Kelly Boothby

Component: commutative algebraalgebra

Changed 14 years ago by Kelly Boothby

Attachment: 5061-steenrod-ao.patch added

comment:3 Changed 14 years ago by Kelly Boothby

Summary: Steenrod algebras report additive order of 0 is p[with patch, needs review] Steenrod algebras report additive order of 0 is p

comment:4 Changed 14 years ago by Robert Bradshaw

Summary: [with patch, needs review] Steenrod algebras report additive order of 0 is p[with patch, needs work] Steenrod algebras report additive order of 0 is p

Looks good. The documentation should probably be fixed as well though, and you need a doctest.

Changed 14 years ago by John Palmieri

Attachment: 5061-doc.patch added

apply on top of other patch

comment:5 Changed 14 years ago by John Palmieri

Summary: [with patch, needs work] Steenrod algebras report additive order of 0 is p[with patch, needs review] Steenrod algebras report additive order of 0 is p

Here's a documentation/doctest patch to go on top of the other one.

comment:6 Changed 14 years ago by Robert Bradshaw

Summary: [with patch, needs review] Steenrod algebras report additive order of 0 is p[with patch, positive review] Steenrod algebras report additive order of 0 is p

I'm happy with it.

comment:7 Changed 14 years ago by Michael Abshoff

Milestone: sage-3.4.1sage-3.4
Resolution: fixed
Status: assignedclosed

Merged both patches in Sage 3.4.rc0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.