Opened 13 years ago

Closed 13 years ago

#5059 closed defect (fixed)

[with patch, positive review] Fix a bunch of broken pickles

Reported by: craigcitro Owned by: craigcitro
Priority: major Milestone: sage-3.3
Component: modular forms Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

At a workshop in Seattle last June, a massive number of spaces of modular symbols were computed. However, the pickles were broken in shortly thereafter by a refactoring of some code in Sage.

The attached patch fixes this -- now the old pickles can be loaded, and new pickles still work fine.

Attachments (2)

trac-5059.patch (3.3 KB) - added by craigcitro 13 years ago.
trac-5059-2.patch (1.4 KB) - added by craigcitro 13 years ago.

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by craigcitro

comment:1 Changed 13 years ago by robertwb

Are there some example broken pickles that this fixes?

comment:2 Changed 13 years ago by robertwb

  • Summary changed from [with patch, needs review] Fix a bunch of broken pickles to [with patch, positive review] Fix a bunch of broken pickles

Some examples: http://sage.math.washington.edu/home/wstein/db/modsym/data/

Looks good and works great.

comment:3 Changed 13 years ago by mabshoff

  • Summary changed from [with patch, positive review] Fix a bunch of broken pickles to [with patch, needs work] Fix a bunch of broken pickles

Unfortunately this patch breaks two doctests:

        sage -t -long devel/sage/sage/modular/congroup.py # 5 doctests failed
        sage -t -long devel/sage/sage/modular/congroup_element.py # 1 doctests failed

Cheers,

Michael

Changed 13 years ago by craigcitro

comment:4 Changed 13 years ago by robertwb

  • Summary changed from [with patch, needs work] Fix a bunch of broken pickles to [with patch, positive review] Fix a bunch of broken pickles

That seems to have addressed those doctest failures.

comment:5 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.3.alpha0

Cheers,

Michael

Note: See TracTickets for help on using tickets.