Changes between Version 31 and Version 37 of Ticket #4949


Ignore:
Timestamp:
01/23/12 23:13:18 (8 years ago)
Author:
jhpalmieri
Comment:

If you run "sage -i blah" and "blah" is an optional spkg which needs to be downloaded, would it make more sense to save the spkg in $SAGE_ROOT/spkg/optional/ or in $SAGE_BUILD_TMPDIR/optional? The previous versions of the patch do the second of these, but I think it makes more sense to do the first: downloading spkg files for optional packages is not the same as building, so setting SAGE_BUILD_TMPDIR shouldn't cause the spkg files to end up somewhere nonstandard. Another way to say it: I don't view downloaded spkg files for optional spkgs as temporary, the way build directories are.

Here's a new patch. I've removed the variables "BUILD" and "BUILD_DIR", and I've appended "build" to the setting of "$SAGE_BUILD_TMPDIR". I still check whether $SAGE_BUILD_TMPDIR exists, as a safeguard against typos, for example. Optional spkgs are kept in $SAGE_PACKAGES/optional regardless of the setting of $SAGE_BUILD_TMPDIR.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4949

    • Property Status changed from positive_review to needs_review
  • Ticket #4949 – Description

    v31 v37  
    33----
    44
    5 Apply [attachment:trac_4949-root.patch] to the Sage '''root repository'''.
     5Apply [attachment:trac_4949-root.v2.patch] to the Sage '''root repository'''.
    66
    77Apply [attachment:trac_4949-installation.patch] to the '''Sage library'''.