Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#4851 closed defect (fixed)

[with patch, positive review] infinite recursion with encoding entities for worksheet titles with apostrophes, etc

Reported by: ddrake Owned by: mhansen
Priority: major Milestone: sage-3.3
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The title seems complicated but the problem is easy to see: if one creates a worksheet with an apostrophe in the title, like this:

I'm an apostrophe

then saves, quits, and reloads the worksheet, the title is now:

I'm an apostrophe

If you quit and reload the worksheet, the title becomes:

I'm an apostrophe

...and so on. The ampersand is replaced by "&", and then THAT ampersand gets replaced by...and so on. The problem seems to happen with any HTML entity. I'm seeing this with 3.2.2.

Attachments (1)

trac_4851.patch (3.0 KB) - added by mhansen 11 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by mhansen

  • Owner changed from boothby to mhansen
  • Status changed from new to assigned
  • Summary changed from infinite recursion with encoding entities for worksheet titles with apostrophes, etc to [with patch, needs review] infinite recursion with encoding entities for worksheet titles with apostrophes, etc

Changed 11 years ago by mhansen

comment:2 Changed 11 years ago by ddrake

  • Summary changed from [with patch, needs review] infinite recursion with encoding entities for worksheet titles with apostrophes, etc to [with patch, positive review] infinite recursion with encoding entities for worksheet titles with apostrophes, etc

The code looks good, and the reported problem is fixed. I give this a positive review provided that a doctest gets added, or a test in the Selenium test suite is added.

comment:3 Changed 11 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 3.3.alpha0

comment:4 Changed 11 years ago by mabshoff

  • Milestone changed from sage-3.4.1 to sage-3.3
Note: See TracTickets for help on using tickets.