Opened 12 years ago

Closed 12 years ago

#4848 closed defect (fixed)

[with patch, positive review] Remove deadwood: sage/schemes/elliptic_curves/heegner.py

Reported by: mabshoff Owned by: mabshoff
Priority: minor Milestone: sage-3.2.3
Component: misc Keywords:
Cc: wstein Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The file sage/schemes/elliptic_curves/heegner.py is mainly some comments and a bunch of Magma code. I don't see anything useful in there, so let's get rid of it.

Long doctests pass with the file and its copies removed from build.

Cheers,

Michael

Attachments (1)

trac_4848.patch (13.0 KB) - added by mabshoff 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by mabshoff

comment:1 Changed 12 years ago by mabshoff

  • Status changed from new to assigned

The file is also from 2005 and hasn't been touched for ages:

changeset:   1097:e9c1649fcc14
user:        wstein@gmail.com
date:        Fri Sep 01 02:31:25 2006 +0000
summary:     [project @ wstein@ucsd.edu --> wstein@gmail.com (hundreds of changes)]

changeset:   0:039f6310c6fe
user:        tornaria@math.utexas.edu
date:        Sat Feb 11 01:13:08 2006 +0000
summary:     [project @ original sage-0.10.12]

Cheers,

Michael

comment:2 Changed 12 years ago by mhampton

  • Cc wstein added
  • Priority changed from major to minor
  • Summary changed from [with patch, needs review] Remove deadwood: sage/schemes/elliptic_curves/heegner.py to [with patch, positive review] Remove deadwood: sage/schemes/elliptic_curves/heegner.py

This is all magma code. If it does something useful then it should be moved upstream or perhaps put in an optional spkg. Since its William Stein's code perhaps he could bless its removal...

comment:3 follow-up: Changed 12 years ago by was

What should happen is that there should be a new *enhancement* ticket that is called "add functionality for computing Heegner points to Sage". Then the file heegner.py should be attached to that ticket, since to do that ticket, one might want to port some of what's in there to Sage. That said, it's not so simple, since better algorithms for computing Heegner points were found after that code was written.

So I am OK with this ticket if and only if the above enhancement ticket is created.

comment:4 in reply to: ↑ 3 Changed 12 years ago by mabshoff

Replying to was:

So I am OK with this ticket if and only if the above enhancement ticket is created.

See #4849.

Cheers,

Michael

comment:5 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 3.2.3.alpha0

Note: See TracTickets for help on using tickets.