Opened 14 years ago
Closed 14 years ago
#4826 closed enhancement (fixed)
[with patch, positive review] change return type of G.cusps() for G a congruence subgroup
| Reported by: | craigcitro | Owned by: | craigcitro |
|---|---|---|---|
| Priority: | major | Milestone: | sage-3.2.3 |
| Component: | modular forms | Keywords: | |
| Cc: | Merged in: | ||
| Authors: | Reviewers: | ||
| Report Upstream: | Work issues: | ||
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description
As pointed out on this thread on sage-nt, it might be more reasonable to have G.cusps() return a list instead of a set (for G a congruence subgroup). In particular, seeing an ordered list as output makes it easier to look through.
The attached patch changes this return type, as well as making a few small fixes so that this is just as fast as before (or faster, in some cases).
This patch depends on #4747.
Attachments (1)
Change History (5)
comment:1 Changed 14 years ago by
- Status changed from new to assigned
- Summary changed from change return type of G.cusps() for G a congruence subgroup to [with patch, needs review] change return type of G.cusps() for G a congruence subgroup
Changed 14 years ago by
comment:2 Changed 14 years ago by
- Summary changed from [with patch, needs review] change return type of G.cusps() for G a congruence subgroup to [with patch, with positive review] change return type of G.cusps() for G a congruence subgroup
comment:3 Changed 14 years ago by
- Milestone changed from sage-3.4 to sage-3.2.3
- Summary changed from [with patch, with positive review] change return type of G.cusps() for G a congruence subgroup to [with patch, positive review] change return type of G.cusps() for G a congruence subgroup
comment:4 Changed 14 years ago by
- Resolution set to fixed
- Status changed from assigned to closed
Merged in Sage 3.2.3.alpha0
Note: See
TracTickets for help on using
tickets.
Patch applied cleanly to 3.2.2.rc1 (after removing the e-acute in Thiery's name in sage/combinat/ranker.py).
All tests in sage/modular pass, as well as some other testing that I did.
Positive review!