Opened 12 years ago
Closed 12 years ago
#4791 closed defect (fixed)
[with patch, with positive review] purge nodoctest.py from the Sage library tree
Reported by: | mabshoff | Owned by: | mabshoff |
---|---|---|---|
Priority: | major | Milestone: | sage-3.2.2 |
Component: | doctest coverage | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
We should doctest every possible file and not put up with any nodoctest.py crap. This keeps certain files from getting doctested, i.e.
sage -t -long devel/sage/sage/dsage/server/stats.py [2.3 s] sage -t -long devel/sage/sage/dsage/server/tests/test_server.py [2.6 s] sage -t -long devel/sage/sage/dsage/twisted/tests/test_pubkeyauth.py [2.4 s] sage -t -long devel/sage/sage/dsage/twisted/tests/test_remote.py [2.5 s] sage -t -long devel/sage/sage/dsage/twisted/pubkeyauth.py [2.6 s] sage -t -long devel/sage/sage/dsage/twisted/pb.py [2.7 s] sage -t -long devel/sage/sage/server/notebook/sage_email.py [2.5 s] sage -t -long devel/sage/sage/quadratic_forms/genera/genus.py [2.7 s]
The following files are removed by this patch:
sage/dsage/database/tests/nodoctest.py sage/dsage/database/nodoctest.py sage/dsage/errors/nodoctest.py sage/dsage/misc/nodoctest.py sage/dsage/scripts/nodoctest.py sage/dsage/server/tests/nodoctest.py sage/dsage/server/nodoctest.py sage/dsage/twisted/tests/nodoctest.py sage/dsage/twisted/nodoctest.py sage/dsage/nodoctest.py sage/quadratic_forms/genera/nodoctest.py sage/server/notebook/compress/nodoctest.py
With my current merge tree -t -long passes.
Cheers,
Michael
Attachments (1)
Change History (3)
Changed 12 years ago by
comment:1 Changed 12 years ago by
- Summary changed from [with patch, needs review] purge nodoctest.py from the Sage library tree to [with patch, with positive review] purge nodoctest.py from the Sage library tree
Yep, I agree that we should remove all these nodoctest.py
files. Anything that pops up should get turned up by the next alpha/rc ...
comment:2 Changed 12 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged in Sage 3.2.2.rc0
Note: See
TracTickets for help on using
tickets.
This is a git style patch