Opened 12 years ago

Closed 12 years ago

#4760 closed defect (fixed)

[with patch, positive review] dsage_interface doctests broken

Reported by: gfurnish Owned by: gfurnish
Priority: major Milestone: sage-3.2.2
Component: dsage Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The doctests in dsage_interface are disabled and do not work properly when enabled. This patch fixes these issues.

Attachments (2)

trac_4760.patch (2.7 KB) - added by gfurnish 12 years ago.
trac_4760-referee.patch (993 bytes) - added by mabshoff 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by gfurnish

comment:1 Changed 12 years ago by mhansen

  • Summary changed from [with patch, needs review] dsage_interface doctests broken to [with patch, positive review] dsage_interface doctests broken

All tests pass for me after #4745 and this patch. I think the doctests should still be rewritten to use start_all since that should be the preferred way to do things.

comment:2 Changed 12 years ago by gfurnish

  • Status changed from new to assigned

comment:3 Changed 12 years ago by mabshoff

The following comment in the file should definitely be deleted:

3	3	Doctesting of this file is disabled because it fails in so many ways it is even funny. 
4	4	See http://trac.sagemath.org/sage_trac/ticket/3593 for two of the four ways I've
<SNIP> 

I will do so via a referee patch.

Cheers,

Michael

Changed 12 years ago by mabshoff

comment:4 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged both patches in Sage 3.2.2.alpha2

Note: See TracTickets for help on using tickets.