Opened 14 years ago

Last modified 6 weeks ago

#4754 needs_work enhancement

Merge minimum rank code

Reported by: jason Owned by: jason
Priority: major Milestone:
Component: graph theory Keywords:
Cc: mvngu Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Based on the discussion at http://groups.google.com/group/sage-support/browse_thread/thread/3ec4cc026e9c65bd, it would be great to merge the code found at http://arxiv.org/abs/0812.1616 into the Sage library. Several functions should probably go into the main graph library (e.g., the edge clique cover function), while others probably ought to go into a minimum_rank.sage file.

I am one of the developers and hereby give my permission to incorporate the code into Sage. I will ask the other developers as well.

Attachments (3)

trac-4754-minrank.patch (43.7 KB) - added by jason 13 years ago.
trac-4754-minrank2.patch (31.8 KB) - added by jason 13 years ago.
apply on top of previous patch
trac-4754-cython-zeroforcing.patch (13.6 KB) - added by jason 13 years ago.
apply on top of previous patches

Download all attachments as: .zip

Change History (19)

comment:1 Changed 14 years ago by jason

Owner: changed from rlm to jason
Status: newassigned

comment:2 Changed 14 years ago by jason

I also have a *much* faster Cython zero-forcing-set tester that I could donate to Sage.

comment:3 Changed 14 years ago by was

while others probably ought to go into a minimum_rank.sage file.

I don't think anything included in the core main sage library should go in a .sage file. It should go in a .py file.

William

comment:4 Changed 14 years ago by jason

From personal email from Geoff Tims, 13 Dec 2008:

Hey Jason,
 
I don't know exactly how I feel.  I'm probably fine with it.
 
I agree to license the code available from http://arxiv.org/abs/0812.1616 as GPL version 2 or later
 
Geoff

comment:5 Changed 14 years ago by jason

From personal email from Tracy McKay?, 11 Dec 2008:

Hi Jason,

I agree to license the code available from http://arxiv.org/abs/0812.1616 as GPL version 2 or later. 

Thanks,

Tracy McKay

comment:6 Changed 14 years ago by jason

From personal email from Laura DeLoss?, 11 Dec 2008:

I agree to license the code available from http://arxiv.org/abs/0812.1616 as GPL version 2 or later and for the EGR group (Jason, Jason, Geoff, Tracy and myself) to be listed as the Sage contributors. 

comment:7 Changed 14 years ago by mvngu

Cc: mvngu added

CC'ing myself

comment:8 Changed 13 years ago by jason

Report Upstream: N/A

Jason Smith also verbally gave me permission to license the code GPLv2 or later.

Changed 13 years ago by jason

Attachment: trac-4754-minrank.patch added

Changed 13 years ago by jason

Attachment: trac-4754-minrank2.patch added

apply on top of previous patch

Changed 13 years ago by jason

apply on top of previous patches

comment:9 Changed 13 years ago by jason

Added rough versions of patches.

comment:10 Changed 13 years ago by jason

Status: newneeds_work

comment:11 Changed 9 years ago by jdemeyer

Milestone: sage-5.11sage-5.12

comment:12 Changed 9 years ago by vbraun_spam

Milestone: sage-6.1sage-6.2

comment:13 Changed 9 years ago by vbraun_spam

Milestone: sage-6.2sage-6.3

comment:14 Changed 8 years ago by vbraun_spam

Milestone: sage-6.3sage-6.4

comment:15 Changed 16 months ago by dcoudert

Is it best to merge the code or to make https://github.com/jasongrout/minimum_rank an optional package ?

comment:16 Changed 6 weeks ago by mkoeppe

Milestone: sage-6.4
Note: See TracTickets for help on using tickets.