Opened 13 years ago

Closed 13 years ago

#4745 closed defect (fixed)

[with patch, positive review] Dsage performance is poor

Reported by: gfurnish Owned by: gfurnish
Priority: major Milestone: sage-3.2.2
Component: dsage Keywords:
Cc: mhansen Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

DSage latency is poor, this patch seeks to improve this by a combination of pushing jobs and improving the speed of which new results are detected. This is the first of many patches that could be made to organically improve DSage, so this is a small patch which should have big results (but there is still plenty of work to be done on DSage.)

Attachments (4)

trac_4745.patch (4.6 KB) - added by gfurnish 13 years ago.
trac_4745_2.patch (2.5 KB) - added by gfurnish 13 years ago.
Apply on top of first patch.
trac_4745_3.patch (763 bytes) - added by gfurnish 13 years ago.
Fix for doctest failure upon reenabling.
trac_4745-combined.patch (6.0 KB) - added by mhansen 13 years ago.

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by gfurnish

Changed 13 years ago by gfurnish

Apply on top of first patch.

comment:1 Changed 13 years ago by gfurnish

  • Status changed from new to assigned

For the record this last patch fixed a race condition that could *potentially* cause #3746 (but theres no guarentee there isn't a different race condition).

Changed 13 years ago by gfurnish

Fix for doctest failure upon reenabling.

comment:2 Changed 13 years ago by mabshoff

  • Cc mhansen added

Mike,

can you put this on your to review list? It would be nice if this went into 3.2.2.

Cheers,

Michael

Changed 13 years ago by mhansen

comment:3 Changed 13 years ago by mhansen

  • Summary changed from [with patch, needs review] Dsage performance is poor to [with patch, positive review] Dsage performance is poor

I attached a folded patch since I wanted one for the review. Really good work on this! It make DSage way more useable.

Just merge the -combined patch.

comment:4 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged trac_4745-combined.patch in Sage 3.2.2.alpha2

Note: See TracTickets for help on using tickets.