Opened 15 years ago

Closed 15 years ago

#473 closed enhancement (fixed)

make the -valgrind target more flexible, add massif support

Reported by: mabshoff Owned by: mabshoff
Priority: minor Milestone: sage-2.8.4
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

At the moment the valgrind tool and flags are hardcoded in various scripts. So add checks for environment flag SAGE_VALGRIND_FLAGS to overwrite default.

To illustrate what you can do with other tools from the valgrind suite have a look at the two attached graphs created by the heap profiler massif.

It might also be nice to add a -valgrind to "sage -testall" to valgrind the whole test suite.

Cheers,

Michael

Attachments (1)

massif.19869.ps (65.5 KB) - added by mabshoff 15 years ago.
example of massif heap profiler

Download all attachments as: .zip

Change History (7)

Changed 15 years ago by mabshoff

example of massif heap profiler

comment:1 Changed 15 years ago by mabshoff

In addition increase the timeout value in sage-doctest to above 180 seconds depending on whether valgrind is used. Otherwise certain tests fail with timeouts:

==31586== Using valgrind-3.2.1, a dynamic binary instrumentation framework.
==31586== Copyright (C) 2000-2006, and GNU GPL'd, by Julian Seward et al.
==31586== For more details, rerun with: -v
==31586==
--31586-- DWARF2 CFI reader: unhandled CFI instruction 0:10
--31586-- DWARF2 CFI reader: unhandled CFI instruction 0:10
==31586==
==31586== Total spacetime:   1,269,947,691,109 ms.B
==31586== heap:              84.8%
==31586== heap admin:        14.6%
==31586== stack(s):           0.4%
*** *** Error: TIMED OUT! *** ***
*** *** Error: TIMED OUT! *** ***
         [222.3 s]

Cheers,

Michael

comment:2 Changed 15 years ago by mabshoff

  • Status changed from new to assigned

comment:3 Changed 15 years ago by was

  • Milestone changed from sage-2.8.3 to sage-2.9

comment:4 Changed 15 years ago by mabshoff

The sage -t -valgrind support should have been added to the 2.8.3 release.

Massif support will come for 2.9.

Cheers,

Michael

comment:6 Changed 15 years ago by was

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.