Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#4700 closed defect (invalid)

Move existing javascript packages in extcode to their own spkg packages

Reported by: jason Owned by: boothby
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges


This ticket moves the jsmath, jquery, jqueryui, and jsmath-image-fonts packages to their own spkgs that install in local/notebook/javascript.

Sorry, mabshoff; it was much easier to group these very related and similar tasks together.

The spkgs are at:

The (huge) patch that deletes things from the extcode repository is at (apply to the extcode repository; we might reset the extcode history, as mabshoff suggested on #4267).

Attachments (1)

javascript-spkg.patch (12.7 KB) - added by jason 13 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by jason

This ticket also takes the opportunity to update each of the javascript packages to the latest version (as of late October, 2008). Some of the changes in the patch reflect the updating (primarily, the updating of jqueryui).

comment:2 Changed 13 years ago by mabshoff

  • Milestone changed from sage-3.2.2 to sage-duplicate/invalid/wontfix
  • Resolution set to invalid
  • Status changed from new to closed


the whole point was that

  1. these tasks are independent
  2. this is again a composite ticket just like #4267

So: invalid.



comment:3 Changed 13 years ago by was

OK, guys calm down. It will be _massively_ easier referee wise if you can break this up into independent tasks, especially because there's still a lot of work to integrate this into sage, even after handing it off. Please please please Jason can you split this into smaller well-defined tasks? Thanks!!

Changed 13 years ago by jason

comment:4 Changed 13 years ago by mabshoff

To elaborate some more why these tickets need to be split up:

  • verifying that the updated jsmath.spkg works is trivial
  • anything touching jquery needs to be reviewed in much more detail, i.e. somebody needs to check that DSage still works, i.e. its GUI
  • jsmath-image-fonts-1.3p0.spkg is an optional spkg, so it should be trivial to review

Mixing and matching seemingly related tickets and then ending up piling fixes on top has proven a disaster time after time, so let's please be nice about this and get this resolved.



PS: Sorry if my tone was out of line, I had just woken up :)

comment:5 Changed 13 years ago by jason

Okay; I saw all of these tasks as very similar, hence the same ticket. It'll be a lot more work to split it up further than this, but I'll get to it eventually.

Note: See TracTickets for help on using tickets.