Opened 12 years ago

Closed 12 years ago

#4699 closed enhancement (fixed)

[with patch, positive review] Rewrite -tp to use pyprocessing

Reported by: ddrake Owned by: gfurnish
Priority: minor Milestone: sage-3.2.2
Component: build Keywords:
Cc: gfurnish Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mabshoff)

Currently -tp uses Pbuild infrastructure, but it would be vastly better to rewrite it using pyprocessing.

Cheers,

Michael

Attachments (3)

trac_4699_new_bin.patch​ (14.6 KB) - added by gfurnish 12 years ago.
apply instead of other patches
trac_4699_new2_bin.patch​ (14.7 KB) - added by gfurnish 12 years ago.
trac_4699_fix.patch​ (2.1 KB) - added by gfurnish 12 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 12 years ago by ddrake

...and, from ​http://trac.sagemath.org/sage_trac/ticket/4684#comment:6:

I think we should postpone any work in that direction until we use pyprocessing for -tp. As it the feature is undocumented since it is still considered experimental due to bad behavior when doctests hang. Once we have #4538 and a pyprocessing based -tp we should finally document its existence.

comment:2 Changed 12 years ago by mabshoff

  • Description modified (diff)
  • Milestone set to sage-3.2.2
  • Summary changed from should be even more easier to change how many threads used for "make ptest" and friends to Rewrite -tp to use pyprocessing

I renamed and changed the ticket description.

Cheers,

Micheal

comment:3 Changed 12 years ago by mabshoff

  • Cc gfurnish added

Also see #838 for something closely related that could be solved using pyprocessing by using an initialized sage session and then forking.

Cheers,

Michael

comment:4 Changed 12 years ago by gfurnish

  • Owner changed from mabshoff to gfurnish
  • Status changed from new to assigned
  • Summary changed from Rewrite -tp to use pyprocessing to [with patch, needs review] Rewrite -tp to use pyprocessing

This also fixes #4711

comment:5 Changed 12 years ago by mabshoff

  • Summary changed from [with patch, needs review] Rewrite -tp to use pyprocessing to [with patch, needs rebase] Rewrite -tp to use pyprocessing

Oops: 

(Stripping trailing CRs from patch.)
patching file sage-ptest
Hunk #2 FAILED at 279.
Hunk #3 FAILED at 291.

Cheers,

Michael

Changed 12 years ago by gfurnish

apply instead of other patches

comment:6 Changed 12 years ago by gfurnish

  • Summary changed from [with patch, needs rebase] Rewrite -tp to use pyprocessing to [with patch, needs review] Rewrite -tp to use pyprocessing

Changed 12 years ago by gfurnish

Changed 12 years ago by gfurnish

comment:7 Changed 12 years ago by mabshoff

  • Summary changed from [with patch, needs review] Rewrite -tp to use pyprocessing to [with patch, positive review] Rewrite -tp to use pyprocessing

Nice work, positive review.

Cheers,

Michael

comment:8 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged trac_4699_fix.patch and trac_4699_new_bin.patch in Sage 3.2.2.alpha2

Note: See TracTickets for help on using tickets.