#4684 closed enhancement (fixed)
[with patch, positive review] should be easier to change how many threads used for "make ptest" and friends
| Reported by: | ddrake | Owned by: | mabshoff |
|---|---|---|---|
| Priority: | major | Milestone: | sage-3.2.2 |
| Component: | build | Keywords: | |
| Cc: | Merged in: | ||
| Authors: | Reviewers: | ||
| Report Upstream: | Work issues: | ||
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description
I just ran a make ptest and was surprised to see my 4-core machine overwhelmed. Of course, that's because the makefile in $SAGE_ROOT defaults to "-tp 12" for all the parallel testing.
I added a variable at the top of the makefile so that the, uh, tiny minority of Sage users with fewer than 16 cores can easily edit the makefile so that parallel testing doesn't kill their machines. :)
Since $SAGE_ROOT isn't under version control, I'm just uploading the entire new makefile. The changes are really simple.
Attachments (2)
Change History (9)
Changed 13 years ago by
comment:1 Changed 13 years ago by
- Summary changed from should be easier to change how many threads used for "make ptest" and friends to [with patch, needs review] should be easier to change how many threads used for "make ptest" and friends
comment:2 Changed 13 years ago by
Changed 13 years ago by
comment:3 Changed 13 years ago by
- Summary changed from [with patch, needs review] should be easier to change how many threads used for "make ptest" and friends to [with patch, positive review] should be easier to change how many threads used for "make ptest" and friends
Looks good to me. I posted a diff between the current and the patched version for the record.
Cheers,
Michael
comment:4 Changed 13 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged in Sage 3.2.2.alpha0
comment:5 Changed 13 years ago by
Hi,
This is already closed, but I want to comment that I would vastly prefer if "make ptest" were to by default just parse the MAKE environment variable, and if it is "make -j6", say, then use 6 threads. This is what "sage -t" does now. This way, I just set MAKE in my .bash_profile, and everything works right.
comment:6 Changed 13 years ago by
I think we should postpone any work in that direction until we use pyprocessing for -tp. As it the feature is undocumented since it is still considered experimental due to bad behavior when doctests hang. Once we have #4538 and a pyprocessing based -tp we should finally document its existence.
Cheers,
Michael
comment:7 Changed 13 years ago by
Oops, I was busy opening #4699 while mabshoff was commenting!
Hi,
please post a diff to the original version of the makefile.
Cheers,
Michael