Opened 13 years ago

Closed 13 years ago

Last modified 6 years ago

#4610 closed defect (fixed)

[with patch, positive review] "sage -tp X": Move certain long doctests to the start of the list of files to test

Reported by: mabshoff Owned by: gfurnish
Priority: critical Milestone: sage-3.2.2
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

There are various doctests in Sage that take a while, chief among those is

sage -t -long devel/sage/sage/crypto/mq/sr.py
 [630.4 s]

When running -tp with a high number of parallel threads those tests end up running at the end and making the user wait a while until that test finishes:

Total time for all tests: 1287.6 seconds

Moving this and a couple other files to the beginning of the list to doctest in local/bin/sage-ptest would likely result in a more even utilization of the cores. This also annoys me personally since I run -tp 8 -long after each patch merged in sage.math and it would shave probably 4 minutes off the total time of each run.

Cheers,

Michael

Attachments (1)

trac_4610_bin.patch (3.4 KB) - added by gfurnish 13 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 13 years ago by mabshoff

  • Status changed from new to assigned
  • Summary changed from "sage -tp X"L Move certain long doctests to the start of the list of files to test to "sage -tp X": Move certain long doctests to the start of the list of files to test

comment:2 Changed 13 years ago by mabshoff

The following doctest take more than 100 seconds on sage.math with the current 3.2.1.a2:

devel/sage/sage/schemes/elliptic_curves/ell_rational_field.py
devel/sage/sage/rings/qqbar.py
devel/sage/sage/schemes/elliptic_curves/sha_tate.py
devel/sage/sage/functions/piecewise.py
devel/sage/sage/graphs/graph_generators.py
devel/sage/sage/groups/perm_gps/partn_ref/refinement_binary.pyx
devel/sage/sage/groups/matrix_gps/matrix_group.py
devel/sage/sage/graphs/graph.py
devel/sage/sage/groups/perm_gps/partn_ref/refinement_matrices.pyx
devel/sage/sage/groups/perm_gps/partn_ref/refinement_graphs.pyx
devel/sage/sage/combinat/root_system/weyl_characters.py
devel/sage/sage/combinat/root_system/weyl_characters.py
devel/sage/sage/calculus/calculus.py
devel/sage/sage/crypto/mq/sr.py

Cheers,

Michael

Changed 13 years ago by gfurnish

comment:3 Changed 13 years ago by gfurnish

  • Owner changed from mabshoff to gfurnish
  • Status changed from assigned to new
  • Summary changed from "sage -tp X": Move certain long doctests to the start of the list of files to test to [with patch, needs review] "sage -tp X": Move certain long doctests to the start of the list of files to test

This patch autotracks timing of files so that they test in the right order.

comment:4 Changed 13 years ago by mabshoff

  • Summary changed from [with patch, needs review] "sage -tp X": Move certain long doctests to the start of the list of files to test to [with patch, positive review] "sage -tp X": Move certain long doctests to the start of the list of files to test

Nice work, positive review. I am adding some tiny additional print statements to keep the user informed.

Cheers,

Michael

comment:5 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.2.2.alpha0

comment:6 Changed 6 years ago by chapoton

  • Description modified (diff)
  • Report Upstream set to N/A
Note: See TracTickets for help on using tickets.